Skip to content

Remove node native runner CNCServer option from settings #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 11, 2016
Merged

Remove node native runner CNCServer option from settings #280

merged 3 commits into from
Oct 11, 2016

Conversation

docprofsky
Copy link
Collaborator

This option has caused problems for users at least two times, and the native runner has no significant performance benefit.

This reverts commit c6deca8, which added the native runner option.

@docprofsky docprofsky added this to the 2.0.0 Full Release milestone Oct 10, 2016
@techninja
Copy link
Contributor

Reverting is all nice and dandy, but we don't wan't the prefill back. 🌮

@docprofsky
Copy link
Collaborator Author

Derp; should I just delete what what was added by c6deca8?

@techninja
Copy link
Contributor

:shipit:

@docprofsky docprofsky merged commit 59df30a into master Oct 11, 2016
@docprofsky docprofsky deleted the no-native-runner branch October 11, 2016 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@techninja techninja techninja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.0 Full Release
Development

Successfully merging this pull request may close these issues.
2 participants
@docprofsky @techninja