Skip to content

Conversation

docprofsky
Copy link
Collaborator

This gets rid of the spiral path and replaces it with maths!
Mostly tested.

@docprofsky
Copy link
Collaborator Author

This has been tested (by @ajpiano and me); it works I am ready to merge.

@techninja techninja self-assigned this Jul 19, 2016
@techninja
Copy link
Contributor

I'll review.

@techninja
Copy link
Contributor

This fixes the original limitations and seems to work pretty well. Unfortunately it doesn't seem to work any better than the previously somewhat UX broken one. On center weighted fills of small objects, UI locking time is wasted iterating outside of the objects bounds. Try filling a small circle and see that it takes a full 40 seconds at very fine fill precision on 10x trace speed. The UI gets no updates during this time and the progress indicator leaves because unless you give an update < 5sec, it hides itself. This is a good indicator that humans have pretty much given up unless you're telling them it's still working.

The cheat I used before was to speed through any time we weren't in the bounding box with inside iterations in a single call.. or something like that. Really there's some easy ways to speed this up that we shouldn't pass up while we're messing with it.

Use intersections to skip along spiral to find where it enters the
fillPath after the spiral has exited the fillPath
@techninja
Copy link
Contributor

Great stuff! I guess we'll be building the beta now.

@techninja techninja merged commit 49ceca4 into master Jul 22, 2016
@docprofsky docprofsky deleted the maths-piral branch July 26, 2016 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants