-
Notifications
You must be signed in to change notification settings - Fork 33
Use math for overlay fill #269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The spiral will always cover all of the drawing area, so once its end is reached we are done.
This has been tested (by @ajpiano and me); it works I am ready to merge. |
I'll review. |
This fixes the original limitations and seems to work pretty well. Unfortunately it doesn't seem to work any better than the previously somewhat UX broken one. On center weighted fills of small objects, UI locking time is wasted iterating outside of the objects bounds. Try filling a small circle and see that it takes a full 40 seconds at very fine fill precision on 10x trace speed. The UI gets no updates during this time and the progress indicator leaves because unless you give an update < 5sec, it hides itself. This is a good indicator that humans have pretty much given up unless you're telling them it's still working. The cheat I used before was to speed through any time we weren't in the bounding box with inside iterations in a single call.. or something like that. Really there's some easy ways to speed this up that we shouldn't pass up while we're messing with it. |
Use intersections to skip along spiral to find where it enters the fillPath after the spiral has exited the fillPath
Great stuff! I guess we'll be building the beta now. |
This gets rid of the spiral path and replaces it with maths!
Mostly tested.