Tracing fix(es) #265
Merged
Tracing fix(es) #265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Taking your word for it that this fixes the rest of the tracing issues :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently when setting a value on a compound path, it does not set the value on any of its children, so only the very first compound path child in
nothing.svgwas being correctly recognized, but as soon as it finished, it couldn't read the data that simply wasn't there. To compound issues, you also can't read thelengthof a compound path. So I've built two new recursive util functions to allow for setting any path value on a compound path/group and all its children, and to do the same for checking the length....at this point I'm suspecting that if you have a compound path with more than one color, it will not be correctly parsed.. but hey, incremental improvements, right? 😜