-
Notifications
You must be signed in to change notification settings - Fork 33
PR: Add i18n translations to colorsets #169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Default colorset in English
French colorset
Spanish - to improve
This looks good, now the code that displays the webpage needs to be updated. |
Could you add more descriptive branch and issue names than "Patch 5" for this something like "Add translations for color names" for the issue name and "translate_colors" for the branch name would be easier to keep track of. |
That is a good idea. I have never done this before. Thank you |
Fixes needed here:
{
"_meta": {
"creator": "techninja",
"target": "en-US",
"release": "0.9.0",
"basetype": "colorset"
},
"info": {
"type": "Generic",
"name": "Standard",
"description": "English text describing this colorset"
},
"colors": {
"black": "Black",
"red": "Red",
"orange": "Orange",
"yellow": "Yellow",
"green": "Green",
"blue": "Blue",
"purple": "Purple",
"brown": "Brown"
}
}
This seems like it might have issues, but if anything, it's likely a good start. _EDIT_: And oh yea, this can't get merged into RoboPaint master without the code to handle colorset translations, otherwise colorset output would be totally broken! @rogerfachini might be able to help with that. |
I will work on adding the colorset translation code when I get home from school. |
@RI0, the format that the files need to be for my code to work is the following. The outline that techninja gave for the JSON files above should be followed, and you can copy the translated word into the rightmost value on a line. The leftmost value (the 'key') we are undecided on, @techninja has a specific way he wants the keys to work, he might interject to let you know. in the colorset.json file in the colorset directory (for ex Generic.json) the value you replace the color with there is the full translation string in the format of ".colors.", for example "generic.colors.yellow". There is a working example of this in my fork here: https://github.com/rogerfachini/robopaint/tree/Colorsets-i18n/resources/colorsets/generic Have a look at generic.json and the i18n folder, let me know if you have any questions. |
I'm going to close this as Roger's #181 PR is handling all the hard parts. Good news is this will likely be done quite soon! |
Is this what you wanted?