Skip to content

Conversation

rogerfachini
Copy link
Collaborator

Fixed the formatting issues where the length of some words causes formatting issues in the menu. Should fix #166.

Result:
english
spanish

Fixed the formatting issues when the size of some words changes in the
settings menu. Should fix #166.
@RI0
Copy link
Contributor

RI0 commented Nov 9, 2014

Please add the French screenshot so we can check it too.

@rogerfachini
Copy link
Collaborator Author

Here we go, just had to fix a few small JSON formatting issues in the French file.
french

@techninja
Copy link
Contributor

Looking pretty good! Some issues:

  • "Installed Color Set:" legend seems to have a fixed width and totally fails on Spanish. This is likely not because of the legend, but the placing of the dropdown, my bad. Maybe we can get away with shucking this dropdown to the right of the box (maybe with right: 2em;) or something
  • Globe probably wants a little more spacing away from the language dropdown. Maybe 10px or 1em or something.
  • I'm not 100% buying the placement of "Reset" under the done button. Yes, there's a confirmation dialog, but hitting reset accidentally is something we'd like to avoid. Maybe after a dash, just to the right of the main "Settings" header? Still in red, smaller font obviously. You may want to experiment visually.

@techninja
Copy link
Contributor

Oh yes! And don't forget, we're supposed to have some kind of very simple markdown parsing here. Bold/italics are given in simple markdown (mostly stars ***reset required***) and that was lost in the translation commits, see if you can track that down.

EDIT: I added a small library for it.. I think. I could be dreaming this.

@RI0
Copy link
Contributor

RI0 commented Nov 9, 2014

I think these are in the French version. I don't seem to have access to it anymore and I am not sure where it has gone. Could someone add it into the i18n folder to make it easier to keep it in line with the Spanish version?

@docprofsky
Copy link
Collaborator

Should reset be a button instead of a link? I noticed that reset does not reset all of the settings in the advanced tab. It does not seem like there is a good location for the reset button near the apply button unless you want it to be like the Recompute your Base Encryption Key Hash button. It may be best placed under the Advanced tab.

Adds markup parsing functionality back, does this by moving code after
translations instead of before.
@techninja techninja merged commit 924c221 into evil-mad:master Nov 10, 2014
@techninja
Copy link
Contributor

@docprofsky If you want to continue the conversation on "reset button" options, open a new issue, or figure out a better option and submit a new PR for it :)

@evil-mad evil-mad locked and limited conversation to collaborators Nov 12, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Settings page has formatting issues
4 participants