[Feature] Add role selection admin / employee / manager when sending invitations #3956

CREDO23 · 2025-07-23T15:57:40Z

Description

Add member role field in the invite form
Keep EMPLOYEE as default role

✅ Checklist

My code follows the project coding style
I reviewed my own code and added comments where needed
I tested my changes locally
I updated or created related documentation if needed
No new warnings or errors are introduced

Summary by CodeRabbit

New Features
- Added role selection to team invitation forms, allowing admins to assign roles (Admin, Employee, Manager) when inviting new members.
- Invitation flow now requires a role to be selected before sending invites.
Bug Fixes
- Improved error handling and validation for role selection during invitations.
Localization
- Added new translations for "Team member role" and "Please select a role" across all supported languages.
Style
- Adjusted dropdown button height in the invite email dropdown for improved UI consistency.

coderabbitai · 2025-07-23T15:57:50Z

"""

Walkthrough

This update introduces role selection functionality to the team invitation flow, allowing admins to specify a role when inviting new members. The change propagates the roleId through the UI, hooks, service, and type definitions. Localization files are updated with new keys for role-related labels and error messages in multiple languages.

Changes

Files/Paths	Change Summary
.../team-member.tsx	Changed `TeamMemberSection` from default to named export.
.../invite-form-modal.tsx, .../invite-modal.tsx	Enhanced invite modals to support role selection, updated state, UI, validation, and invite logic to include `roleId`.
.../team-members.tsx	Switched user retrieval from hook to global state atom.
.../invite/invite-email-dropdown.tsx	Changed dropdown button height from 54px to 3rem.
.../use-team-invitations.ts	Updated `inviteUser` to accept and pass `roleId`; mutation now includes `roleId` in API call.
.../use-roles.ts	Restricted roles fetching to admin users by checking user role in hook logic.
.../invite.service.ts	Changed invite API to prioritize provided `roleId` over default employee role.
.../invite.ts	Added `roleId: string` property to `IInviteRequest` interface.
.../locales/ar.json, .../bg.json, .../de.json, .../en.json, .../es.json, .../fr.json, .../he.json, .../it.json, .../nl.json, .../pl.json, .../pt.json, .../ru.json, .../zh.json	Added localization keys for team member role label and select role error message in multiple languages.

Sequence Diagram(s)

sequenceDiagram
  participant AdminUser
  participant InviteModal
  participant RolesHook
  participant InviteService
  participant API

  AdminUser->>InviteModal: Open invite modal
  InviteModal->>RolesHook: Fetch available roles (if admin)
  RolesHook-->>InviteModal: Return roles list
  AdminUser->>InviteModal: Fill email, name, select role
  InviteModal->>InviteService: inviteUser(email, name, roleId)
  InviteService->>API: POST /invite { email, name, roleId, ... }
  API-->>InviteService: Success/Failure
  InviteService-->>InviteModal: Result
  InviteModal-->>AdminUser: Show success/error

Estimated code review effort

3 (~45 minutes)

Suggested labels

WEB, feature, Ever Teams

Suggested reviewers

Cedric921
evereq

Poem

🐇
A hop and a skip, new roles on display,
Invite your teammates in a more tailored way!
With dropdowns and checks, and translations anew,
The team grows stronger, thanks to all of you.
So pick a good role, and let’s celebrate—
Ever Teams just got even more great!
🌱
"""

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

yarn install v1.22.22
[1/4] Resolving packages...
(node:31655) [DEP0169] DeprecationWarning: url.parse() behavior is not standardized and prone to errors that have security implications. Use the WHATWG URL API instead. CVEs are not issued for url.parse() vulnerabilities.
(Use node --trace-deprecation ... to show where the warning was created)
error Couldn't find package "@ever-teams/eslint-config@" required by "@ever-teams/types@" on the "npm" registry.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8ee90bc and 739dee9.

📒 Files selected for processing (1)

apps/web/core/services/client/api/organizations/teams/invites/invite.service.ts (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

apps/web/core/services/client/api/organizations/teams/invites/invite.service.ts

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

GitHub Check: Codacy Static Code Analysis
GitHub Check: deploy
GitHub Check: Analyze (javascript-typescript)

✨ Finishing Touches

📝 Generate Docstrings

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch ETP-55-task-add-role-selection-admin-employee-when-sending-invitations

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions · 2025-07-23T15:58:10Z

⚠️ Unused code detected in the following changed files:

apps/web/core/components/common/team-member.tsx
apps/web/core/components/features/teams/invite-modal.tsx
apps/web/core/types/interfaces/user/invite.ts

Please review these files and clean up the unused code.

greptile-apps

Greptile Summary

This PR implements role selection functionality for team invitations, allowing administrators to assign specific roles (Admin, Employee, Manager) when inviting new team members. The feature adds a role dropdown to invitation forms that is only visible to admin and super admin users, while maintaining Employee as the default role for backward compatibility.

Key changes include:

Backend Integration: The IInviteRequest interface now includes a roleId field, and the invitation service was updated to use the provided role ID or fall back to the Employee role. The team invitations hook was extended to accept and pass through the roleId parameter.

UI Components: Two main invitation modals (invite-form-modal.tsx and invite-modal.tsx) were enhanced with role selection dropdowns that appear only for admin users. The components implement proper state management for role selection with validation to ensure a role is selected before submission.

Internationalization: Comprehensive localization support was added across all supported languages (Arabic, Bulgarian, Chinese, Dutch, English, French, German, Hebrew, Italian, Polish, Portuguese, Russian, Spanish) with two new translation keys: TEAM_MEMBER_ROLE for the form field label and SELECT_ROLE for validation error messages.

Minor Optimizations: Some components were refactored for performance, including switching from the useAuthenticateUser hook to direct atom access in team-members.tsx, and the TeamMemberSection component was changed from default to named export for better module organization.

The implementation maintains security by restricting role selection to admin users only and preserves existing functionality through proper fallback mechanisms.

Confidence score: 2/5

• This PR has implementation issues that could cause runtime errors and inconsistent behavior
• State management inconsistencies in invite modals where form data doesn't sync with role selection state, missing roleId in initialValues causing type mismatches, and potential undefined values being passed to APIs
• Files needing attention: apps/web/core/components/features/teams/invite-modal.tsx and apps/web/core/components/features/teams/invite-form-modal.tsx for state management fixes

_{21 files reviewed, 4 comments}

_{Edit Code Review Bot Settings | Greptile}

apps/web/core/components/features/teams/invite-form-modal.tsx

apps/web/core/components/features/teams/invite-modal.tsx

coderabbitai

Actionable comments posted: 3

🔭 Outside diff range comments (1)

apps/web/core/components/features/teams/invite-form-modal.tsx (1)
143-145: Add missing dependency to useCallback.

The handleSubmit callback should include selectedRoleId in its dependency array since it's used in the validation logic.
-[selectedEmail, teamInvitations, closeModal, t, inviteUser, resendTeamInvitation]
+[selectedEmail, teamInvitations, closeModal, t, inviteUser, resendTeamInvitation, selectedRoleId]

🧹 Nitpick comments (3)

apps/web/locales/es.json (1)

1074-1076: Unintended change to VALID_EMAIL?

"VALID_EMAIL" is flagged as modified although its text is identical. Make sure this wasn’t a formatting-only change that could create noisy diffs in future PRs.
Also, consider using the same punctuation style as the earlier "SELECT_ROLE" under common (Por favor, selecciona un rol) for consistency.

apps/web/locales/he.json (1)

1074-1076: Consistency of error strings

The new error string "SELECT_ROLE": "אנא בחר תפקיד" looks good.
Minor: a trailing period (.) is used in several other error messages in this section—worth adding here for stylistic consistency.

apps/web/locales/de.json (1)

1075-1076: Error messages consistent

Both "VALID_EMAIL" and "SELECT_ROLE" follow the existing style. Consider using exactly the same wording for "SELECT_ROLE" if the string also appears in other sections to avoid subtle inconsistencies, but this is optional.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e4b82fa and 5240b02.

📒 Files selected for processing (22)

apps/web/core/components/common/team-member.tsx (1 hunks)
apps/web/core/components/features/teams/invite-form-modal.tsx (4 hunks)
apps/web/core/components/features/teams/invite-modal.tsx (4 hunks)
apps/web/core/components/pages/teams/team/team-members.tsx (3 hunks)
apps/web/core/components/teams/invite/invite-email-dropdown.tsx (1 hunks)
apps/web/core/hooks/organizations/teams/use-team-invitations.ts (3 hunks)
apps/web/core/hooks/roles/use-roles.ts (2 hunks)
apps/web/core/services/client/api/organizations/teams/invites/invite.service.ts (1 hunks)
apps/web/core/types/interfaces/user/invite.ts (1 hunks)
apps/web/locales/ar.json (2 hunks)
apps/web/locales/bg.json (2 hunks)
apps/web/locales/de.json (2 hunks)
apps/web/locales/en.json (2 hunks)
apps/web/locales/es.json (2 hunks)
apps/web/locales/fr.json (2 hunks)
apps/web/locales/he.json (2 hunks)
apps/web/locales/it.json (2 hunks)
apps/web/locales/nl.json (2 hunks)
apps/web/locales/pl.json (2 hunks)
apps/web/locales/pt.json (2 hunks)
apps/web/locales/ru.json (2 hunks)
apps/web/locales/zh.json (2 hunks)

🧠 Learnings (22)

📓 Common learnings

Learnt from: CREDO23
PR: ever-co/ever-teams#3532
File: apps/web/components/pages/team/tasks/DropdownMenuTask.tsx:20-21
Timestamp: 2025-01-21T18:44:28.130Z
Learning: In the Ever Teams application, task assignment operations require member information obtained through the `useTeamMemberCard` hook, which needs the team member object as an argument. This member object is typically found by matching the current user's ID with the employee user ID in the active team's members list.

apps/web/core/components/teams/invite/invite-email-dropdown.tsx (3)

Learnt from: CREDO23
PR: #3360
File: apps/web/components/pages/task/details-section/blocks/task-secondary-info.tsx:346-354
Timestamp: 2024-11-25T18:49:15.126Z
Learning: In apps/web/components/pages/task/details-section/blocks/task-secondary-info.tsx, within the ProjectDropDown component, both parent and child state should be synchronized for better UI updates, even in controlled mode. The onChange function carries the parent state, and setSelected maintains the selected state in the child component.

Learnt from: NdekoCode
PR: #3189
File: apps/web/components/ui/sidebar.tsx:77-87
Timestamp: 2024-10-25T15:15:45.111Z
Learning: In apps/web/components/ui/sidebar.tsx, modifications to the keyboard shortcut implementation within React.useEffect can cause build errors. The current implementation has been validated by shadcn-ui and should remain unchanged.

Learnt from: NdekoCode
PR: #3189
File: apps/web/components/ui/sidebar.tsx:77-87
Timestamp: 2024-10-25T15:15:35.107Z
Learning: In apps/web/components/ui/sidebar.tsx, keyboard shortcut accessibility has already been reviewed and approved by shadcn-ui; further suggestions in this area are unnecessary.

apps/web/core/components/common/team-member.tsx (8)

Learnt from: NdekoCode
PR: #3189
File: apps/web/components/ui/sidebar.tsx:77-87
Timestamp: 2024-10-25T15:15:45.111Z
Learning: In apps/web/components/ui/sidebar.tsx, modifications to the keyboard shortcut implementation within React.useEffect can cause build errors. The current implementation has been validated by shadcn-ui and should remain unchanged.

Learnt from: NdekoCode
PR: #3328
File: apps/web/lib/features/team/user-team-card/user-team-card-activity.tsx:66-78
Timestamp: 2024-11-13T05:17:33.527Z
Learning: In the UserTeamActivity component (apps/web/lib/features/team/user-team-card/user-team-card-activity.tsx), the overflow-hidden class is intentionally applied only to the first Tab.Panel because the hidden overflow is needed when the sub-component has not yet been made visible. Applying overflow-hidden to the other Tab.Panel components is not required.

Learnt from: CREDO23
PR: #3626
File: apps/web/app/[locale]/projects/components/page-component.tsx:119-119
Timestamp: 2025-02-28T09:17:46.802Z
Learning: In the projects page component, filtering of projects based on the active team has been moved out of the useEffect hook that fetches organization projects, and is now handled in the pagination logic instead.

Learnt from: NdekoCode
PR: #3199
File: apps/web/components/app-sidebar.tsx:49-55
Timestamp: 2024-10-28T17:16:03.609Z
Learning: In apps/web/components/app-sidebar.tsx, hardcoded sample user data is intentionally included and should not be removed.

Learnt from: NdekoCode
PR: #3199
File: apps/web/app/stores/team-tasks.ts:39-40
Timestamp: 2024-10-28T17:23:01.110Z
Learning: The favoriteTasksAtom in apps/web/app/stores/team-tasks.ts is important for future implementations and should not be removed, even if it appears unused currently.

Learnt from: CREDO23
PR: #3353
File: apps/web/lib/features/task/task-input.tsx:812-815
Timestamp: 2024-11-20T19:56:12.313Z
Learning: In apps/web/lib/features/task/task-input.tsx, prefer using useRef over useState for assignees in the AssigneesSelect component to prevent re-renders on change.

Learnt from: CREDO23
PR: #3532
File: apps/web/components/pages/team/tasks/DropdownMenuTask.tsx:20-21
Timestamp: 2025-01-21T18:44:28.130Z
Learning: In the Ever Teams application, task assignment operations require member information obtained through the useTeamMemberCard hook, which needs the team member object as an argument. This member object is typically found by matching the current user's ID with the employee user ID in the active team's members list.

Learnt from: NdekoCode
PR: #3234
File: apps/web/components/pages/team/tasks/TaskTable.tsx:9-13
Timestamp: 2024-11-06T17:10:06.239Z
Learning: In the TaskTable component (apps/web/components/pages/team/tasks/TaskTable.tsx), we do not need to add error handling for task fetching when using useTeamTasks().

apps/web/core/components/pages/teams/team/team-members.tsx (9)