apps/web/components/ui/export-dialog.tsx (2)

29-34: Update success message timing

The dialog shows a success message before the user has actually downloaded the file, which could be confusing. Consider showing a progress indicator during export preparation and only showing the success message after the download has completed.

---

41-41: Make the report title dynamic

Currently, the PDF is always titled "Productivity Report by Date" regardless of the actual content or grouping of the report. Consider making this title dynamic based on the groupByType or other relevant parameters.

apps/web/app/[locale]/dashboard/app-url/components/ProductivityPDF.tsx (3)

12-195: Consider refactoring styles for better maintainability.

The styles object is quite large and could benefit from being broken down into smaller, more manageable sections. Consider:

1. Extracting common styles into reusable variables
2. Grouping related styles (header, table, summary, etc.)
3. Moving styles to a separate file

This would improve code readability and maintainability.

---

296-297: Remove unnecessary empty lines.

These empty lines don't serve any purpose and should be removed.

  };

-

-
  return (

---

334-366: Use more reliable unique keys for list items.

The current key generation might not guarantee uniqueness in all cases. Consider using more reliable unique identifiers if available in the data.

If the activity objects have unique IDs, consider using those instead:

-                    <View style={styles.memberRow} key={`${index}-${empIndex}-${projIndex}-${actIndex}`}>
+                    <View style={styles.memberRow} key={activity.id || `${index}-${empIndex}-${projIndex}-${actIndex}`}>

If activity IDs aren't available, the current approach is acceptable but keep in mind potential issues with very large datasets.

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

apps/web/components/ui/export-dialog.tsx (2)

39-55: ⚠️ Potential issue

Missing CSV export implementation

According to the PR objectives, the export functionality should support CSV format, but there's no implementation for it in the code.

Add support for CSV export:

         {reportData && exportType === 'xlsx' && (
           <Button variant="outline" size="sm" >
             Download XLSX
           </Button>
         )}
+         {reportData && exportType === 'csv' && (
+           <Button 
+             variant="outline" 
+             size="sm" 
+             onClick={() => handleCSVExport(reportData)}
+           >
+             Download CSV
+           </Button>
+         )}

You'll need to implement the handleCSVExport function to process the report data and generate the CSV file.

---

51-55: ⚠️ Potential issue

XLSX download button is missing an onClick handler

The XLSX download button is present but doesn't have any functionality attached to it. You need to implement the XLSX export handler to make this work.

-         {reportData && exportType === 'xlsx' && (
-           <Button variant="outline" size="sm" >
-             Download XLSX
-           </Button>
-         )}
+         {reportData && exportType === 'xlsx' && (
+           <Button 
+             variant="outline" 
+             size="sm" 
+             onClick={() => handleXLSXExport(reportData)}
+           >
+             Download XLSX
+           </Button>
+         )}

You'll need to implement the handleXLSXExport function to process the report data and generate the XLSX file.

apps/web/components/ui/export-dialog.tsx (3)

20-21: Consider using a more specific type for reportData

The reportData property is typed as any[] | undefined, which loses type safety. Consider defining a more specific interface or type for your report data to ensure type checking and better IDE support.

-	reportData?: any[] | undefined;
+	reportData?: ReportDataItem[] | undefined;

You could define a ReportDataItem interface that matches the expected structure of your report data.

---

41-41: Consider making the PDF title dynamic

The title for the PDF is hardcoded as 'Productivity Report by Date'. Consider making it dynamic based on the report type or adding it as a prop to the ExportDialog component.

-              document={<ProductivityPDF data={reportData} title={'Productivity Report by Date'} />}
+              document={<ProductivityPDF data={reportData} title={title || 'Productivity Report by Date'} />}

You would need to update the ExportDialogProps interface to include a title property:

interface ExportDialogProps {
  isOpen: boolean;
  onClose: () => void;
  exportType?: string;
  reportData?: any[] | undefined;
  title?: string;
}

---

24-24: Consider using an enum for exportType

Using a string for exportType might lead to errors if a typo is made. Consider using an enum to ensure type safety.

+enum ExportType {
+  PDF = 'pdf',
+  CSV = 'csv',
+  XLSX = 'xlsx'
+}
+
 interface ExportDialogProps {
 	isOpen: boolean;
 	onClose: () => void;
-	exportType?: string;
+	exportType?: ExportType;
 	reportData?: any[] | undefined;
 }

Then update the conditions accordingly:

-       {reportData && exportType === 'pdf' && (
+       {reportData && exportType === ExportType.PDF && (

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro