Describes Eventlet's Alternatives Into the Migration Guide #971
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #971 +/- ##
=====================================
Coverage 56% 56%
=====================================
Files 89 89
Lines 9791 9791
Branches 1826 1826
=====================================
+ Hits 5491 5499 +8
+ Misses 3929 3919 -10
- Partials 371 373 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
01bb9aa to
dbe5809
Compare
|
related to #972 |
There was a problem hiding this comment.
Much of this is fine, but the facade pattern document seems either incomplete or very misleading, it's unclear what it's proposing and it's unclear if people reading it will interpret it consistently.
I have a vague sense of what it's aiming at, maybe ("here's how to make a library that works with both asyncio and blocking threads"), but I could be wrong! And even if I'm right, it leaves out key points ("you'll have to drop eventlet completely" and "this is for libraries only").
|
Thanks @itamarst for your previous review, I'll rework my copy |
This is the beginning of the implementation of the migration guide proposed here: https://review.opendev.org/c/openstack/governance/+/902585 The goal is to centralize all the materials we have to help users to safely migrate off of Eventlet.
|
I decided to temporarely remove the facade pattern from this PR. I'll rework the pattern stuffs in a second time. I'll address your comment related to the pattern, but I also think that I'll more speak about it like a "going further with asyncio" once the migration is done, @itamarst what do you think about this semantic? |
|
I also amended our glossary with new definitions. |
|
Explaining that the facade is useful after completely migrating off of Eventlet makes sense, yeah. "You're no longer using Eventlet at all, how do you have libraries that provide both async and non-async APIs" |
|
|
||
| For the second use case, we believe this is a fundamentally unsustainable approach and encourage the upstream frameworks to come up with different solutions. | ||
| For the second use case, we believe this is a fundamentally unsustainable |
There was a problem hiding this comment.
The existence of awaitlet suggests we should direct people there, maybe?
This is the beginning of the implementation of the migration guide proposed here:
https://review.opendev.org/c/openstack/governance/+/902585
The goal is to centralize all the materials we have to help users to safely migrate off of Eventlet.
It document patterns and methodology.
It will be followed by other pull requests that will reflect the other points made into the proposal.