Upgrade RLocks as last thing we do #970
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #970 +/- ##
=====================================
- Coverage 56% 56% -1%
=====================================
Files 89 89
Lines 9773 9783 +10
Branches 1821 1824 +3
=====================================
- Hits 5489 5486 -3
- Misses 3914 3926 +12
- Partials 370 371 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
4383
approved these changes
Jul 2, 2024
|
Feel free to merge it if you think you are done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #969
Also hide an upgradable RLock in some edge cases.
I tried writing a test but completely failed at getting it to reproduce when run via pytest (it always passes regardless), even though it does reproduce when run manually 😢 So I didn't check it in.