-
Notifications
You must be signed in to change notification settings - Fork 85
Fix privacy request detail page layout issues with long titles #6389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
lucanovera
merged 8 commits into
main
from
ENG-1042-Privacy-request-detail-page-layout-issue-causes-horizontal-scroll
Jul 28, 2025
Merged
Fix privacy request detail page layout issues with long titles #6389
lucanovera
merged 8 commits into
main
from
ENG-1042-Privacy-request-detail-page-layout-issue-causes-horizontal-scroll
Jul 28, 2025
+56
−54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
…request-detail-page-layout-issue-causes-horizontal-scroll
jpople
reviewed
Jul 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jpople
approved these changes
Jul 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks for the update!
…issue-causes-horizontal-scroll
fides
|
Project |
fides
|
Branch Review |
main
|
Run status |
|
Run duration | 00m 57s |
Commit |
|
Committer | Lucano Vera |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
0
|
|
0
|
|
0
|
|
0
|
|
5
|
Upgrade your plan to view test results. | |
View all changes introduced in this branch ↗︎ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
Fix issue where very long title cause an horizontal scroll in the privacy request detail page.
Code Changes
Steps to Confirm
a. A horizontal scroll should never occur
b. when the entry has a short title, every part of the entry (author, title, date, tag) displays one after the other, leaving empty space to the right, like this:
(Local testing quick alternative)
Testing locally, the issue can be reproduced by editing the ActivityTimelineEntry.tsx file and repeating the {title} a bunch of times or setting it to a really long string.
Pre-Merge Checklist
CHANGELOG.md
updatedmain
downgrade()
migration is correct and works