Skip to content

Conversation

nrxsmith
Copy link
Contributor

@nrxsmith nrxsmith commented Jul 25, 2025

Closes ENG-1035

Description Of Changes

A prior PR added this env parameter into the Docker build, but the way the fides-js build script works, it's specifying a specific set of env parameters. So we need to explicitly pass it, rather than relying on process.env.

Code Changes

  • Update fides-js npm build script to parse and pass the IS_TEST env variable

Steps to Confirm

  1. Get the privacy center up and running
  2. Run npm run build on fides-js to see the testids removed.
  3. Set the IS_TEST env variable in the console by running export IS_TEST=true
  4. Run npm run build again; the testids should now be present. (For example, in the Manage Preferences button).

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

Copy link

vercel bot commented Jul 25, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Jul 25, 2025 6:37pm
fides-privacy-center ⬜️ Ignored (Inspect) Jul 25, 2025 6:37pm

@nrxsmith nrxsmith merged commit a43b6d1 into main Jul 25, 2025
17 checks passed
@nrxsmith nrxsmith deleted the use-is-test-in-build branch July 25, 2025 19:08
Copy link

cypress bot commented Jul 25, 2025

fides    Run #13161

Run Properties:  status check passed Passed #13161  •  git commit a43b6d1186: Use IS_TEST in fides-js build script (#6385)
Project fides
Branch Review main
Run status status check passed Passed #13161
Run duration 00m 50s
Commit git commit a43b6d1186: Use IS_TEST in fides-js build script (#6385)
Committer Nate Smith
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 5
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants