-
Notifications
You must be signed in to change notification settings - Fork 85
Update datamap to use react flow #6381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plus remove extra spacing
Co-authored-by: Jason Gill <jason.gill@ethyca.com>
Co-authored-by: Jason Gill <jason.gill@ethyca.com>
Co-authored-by: Jason Gill <jason.gill@ethyca.com>
Co-authored-by: Jason Gill <jason.gill@ethyca.com>
Co-authored-by: Jason Gill <jason.gill@ethyca.com>
Co-authored-by: Jason Gill <jason.gill@ethyca.com>
- Move useDatamapGraph hook to hooks/useDatamapGraph.ts - Improve code organization and reusability - Keep DatamapGraph.tsx focused on component logic - Clean up unused imports
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Kelsey-Ethyca
commented
Jul 27, 2025
gilluminate
approved these changes
Jul 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Excited for this change. I'll help test in RC
fides
|
Project |
fides
|
Branch Review |
main
|
Run status |
|
Run duration | 00m 53s |
Commit |
|
Committer | Kelsey Thomas |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
0
|
|
0
|
|
0
|
|
0
|
|
5
|
Upgrade your plan to view test results. | |
View all changes introduced in this branch ↗︎ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes ENG-159
Screen.Recording.2025-07-18.at.4.52.15.PM.mov
Description Of Changes
This PR completely refactors the datamap visualization from Cytoscape.js to ReactFlow + Dagre layout engine. This migration provides better React integration, improved performance, and more maintainable code architecture. The new implementation includes enhanced accessibility features, proper CSS modules, and a more responsive user interface.
Key architectural changes include replacing the imperative Cytoscape API with declarative ReactFlow components, implementing automatic layout using Dagre for connected components and grid layout for isolated nodes, and moving from inline styles to CSS modules with proper hover/focus states.
Code Changes
Core Migration:
CytoscapeGraph
component with newDatamapGraph
using ReactFlow@dagrejs/dagre
v1.1.4 and@types/dagre
v0.7.52New Components:
DatamapSystemNode.tsx
- Custom ReactFlow node component for system visualizationDatamapGraph.tsx
- Main graph visualization component with ReactFlow integrationuseDatamapGraph
custom hook for data transformation and layout logicgetLayoutedElements
utility function for Dagre positioningContext & State Management:
DatamapGraphContext
and related context providersDatamapGraphStore
component wrapperImport Path Updates:
DataFlowAccordionForm.tsx
,CustomFieldModal.tsx
, and other affected filesTrashCanSolidIcon
) to use correct pathsTesting Updates:
datamap.cy.ts
androutes.cy.ts
UI/UX Improvements:
SettingsBar
componentSteps to Confirm
Basic Functionality:
Layout & Interaction:
Accessibility:
Performance:
Integration:
Pre-Merge Checklist
CHANGELOG.md
updatedmain
downgrade()
migration is correct and works