-
Notifications
You must be signed in to change notification settings - Fork 86
ENG-856 memory manager #6375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENG-856 memory manager #6375
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6375 +/- ##
==========================================
+ Coverage 87.12% 87.14% +0.02%
==========================================
Files 454 455 +1
Lines 29046 29179 +133
Branches 3231 3244 +13
==========================================
+ Hits 25305 25427 +122
- Misses 3016 3025 +9
- Partials 725 727 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I just left one comment about some extra code we should remove. I don't want to hold this up from getting into the release so we can merge after the change, and test during our QA period.
fides
|
Project |
fides
|
Branch Review |
main
|
Run status |
|
Run duration | 01m 05s |
Commit |
|
Committer | Thabo Fletcher |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
0
|
|
0
|
|
0
|
|
0
|
|
5
|
Upgrade your plan to view test results. | |
View all changes introduced in this branch ↗︎ |
Co-authored-by: Adrian Galvan <adrian@ethyca.com>
Closes ENG-856
Incorporates @galvana's change in the
memory-watch
branch, and adds tests and cleans up testing connector.The testing connector can still be obtained from this branch:
ENG-856-memory-manager-testing-setup
and also includes commenting out some code that I had to modify on order to get the testing connector to load on my machine.Code Changes
Steps to Confirm
curl --request PATCH
--url 'http://localhost:3000/api/v1/config?api_set=true'
--header 'Authorization: Bearer YOUR_TOKEN'
--header 'Content-Type: application/json'
--data '
{
"execution": {
"memory_watchdog_enabled": true
}
}'
Followed by a GET to the same endpoint
Pre-Merge Checklist
CHANGELOG.md
updatedmain
downgrade()
migration is correct and works