Skip to content

Conversation

thabofletcher
Copy link
Contributor

@thabofletcher thabofletcher commented Jul 22, 2025

Closes ENG-856

Incorporates @galvana's change in the memory-watch branch, and adds tests and cleans up testing connector.

The testing connector can still be obtained from this branch: ENG-856-memory-manager-testing-setup and also includes commenting out some code that I had to modify on order to get the testing connector to load on my machine.

Code Changes

  • Adrian's memory watchdog
  • Configuration to enable the memory watchdog (defaults to off)
  • Tests that prove the configuration works and tests for the memory watchdog itself

Steps to Confirm

  1. Verify the configuration using this API call:

curl --request PATCH
--url 'http://localhost:3000/api/v1/config?api_set=true'
--header 'Authorization: Bearer YOUR_TOKEN'
--header 'Content-Type: application/json'
--data '
{
"execution": {
"memory_watchdog_enabled": true
}
}'

Followed by a GET to the same endpoint

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

Copy link

vercel bot commented Jul 22, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Jul 30, 2025 9:42pm
fides-privacy-center ⬜️ Ignored (Inspect) Jul 30, 2025 9:42pm

@thabofletcher thabofletcher changed the title Eng 856 memory manager ENG-856 memory manager Jul 22, 2025
Copy link

codecov bot commented Jul 23, 2025

Codecov Report

❌ Patch coverage is 91.72932% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.14%. Comparing base (bf4ac9d) to head (b0f2c76).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/fides/api/task/graph_task.py 38.88% 9 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6375      +/-   ##
==========================================
+ Coverage   87.12%   87.14%   +0.02%     
==========================================
  Files         454      455       +1     
  Lines       29046    29179     +133     
  Branches     3231     3244      +13     
==========================================
+ Hits        25305    25427     +122     
- Misses       3016     3025       +9     
- Partials      725      727       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@galvana galvana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I just left one comment about some extra code we should remove. I don't want to hold this up from getting into the release so we can merge after the change, and test during our QA period.

@thabofletcher thabofletcher merged commit af6c240 into main Jul 30, 2025
25 checks passed
@thabofletcher thabofletcher deleted the ENG-856-memory-manager branch July 30, 2025 21:57
Copy link

cypress bot commented Jul 30, 2025

fides    Run #13190

Run Properties:  status check passed Passed #13190  •  git commit af6c240de9: ENG-856 memory manager (#6375)
Project fides
Branch Review main
Run status status check passed Passed #13190
Run duration 01m 05s
Commit git commit af6c240de9: ENG-856 memory manager (#6375)
Committer Thabo Fletcher
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 5
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

thabofletcher added a commit that referenced this pull request Jul 31, 2025
Co-authored-by: Adrian Galvan <adrian@ethyca.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants