Skip to content

Conversation

lucanovera
Copy link
Contributor

@lucanovera lucanovera commented Jul 21, 2025

Description Of Changes

Update clients to support uploading multiple attachments instead of just one, when completing a manual task from

Code Changes

  • Update types
  • Removed max count for Ant Upload files
  • Update both CompleteModals and both manual task slices (admin-ui and external-task ui in privacy center) to support multiple attachments
  • Added a cypress test, updated the other ones

Steps to Confirm

  1. Setup an Manual Task integration with multiple file task fields and assign it to an external user
  2. Go to Request Manager and create a new request
  3. Approve the new request
  4. Go to manual task and solve one of the file tasks uploading multiple files
  5. Login in the external task portal and complete another file task uploading multiple files
  6. Back in admin-ui, go to that last privacy request and check that in the Activity view it shows the completed task and it shows "2 attachments", the tooltip should should the filenames for the 2 attachments submitted.

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

Copy link

vercel bot commented Jul 21, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 22, 2025 2:56pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-privacy-center ⬜️ Ignored (Inspect) Jul 22, 2025 2:56pm

Copy link
Contributor

@JadeCara JadeCara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified locally with back end changes.

@lucanovera lucanovera merged commit 0522948 into main Jul 22, 2025
21 checks passed
@lucanovera lucanovera deleted the ENG-959-FE-Support-multiple-attachments-in-manual-tasks-file-upload-input branch July 22, 2025 15:20
Copy link

cypress bot commented Jul 22, 2025

fides    Run #13144

Run Properties:  status check passed Passed #13144  •  git commit 0522948a1f: Support uploading multiple attachments in a manual task (#6370)
Project fides
Branch Review main
Run status status check passed Passed #13144
Run duration 00m 50s
Commit git commit 0522948a1f: Support uploading multiple attachments in a manual task (#6370)
Committer Lucano Vera
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 5
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants