Skip to content

Conversation

gilluminate
Copy link
Contributor

Description Of Changes

Adds pino-pretty to the Privacy Center to provide more readable, formatted server-side logs during development. The logger creation has been refactored to support this. Also includes a small refactor to the fides-js rollup config to reduce duplication and for better mjs support. Addresses some of the logger deprecation warnings by updating some SCSS files to use the modern @use syntax.

Code Changes

  • clients/privacy-center:
    • Added pino-pretty dev dependency to format server-side logs in development.
    • Updated logger.ts and requestLogger.ts to use pino-pretty when NODE_ENV is development.
    • Added global TypeScript definitions for fidesDebugger and fidesError.
  • clients/fides-js:
    • Refactored rollup.config.mjs to de-duplicate common plugins across build outputs.
  • clients/fidesui:
    • Updated global.scss to use the modern Sass @use module syntax.

Steps to Confirm

  1. Run npm install in the clients directory.
  2. Run npm run dev in the clients/privacy-center directory.
  3. Access the Privacy Center in your browser (e.g., navigate to http://localhost:3001).
  4. Observe the terminal where you ran the dev command. The server-side logs from Next.js should now be colorized and pretty-printed, instead of appearing as raw JSON objects.
CleanShot 2025-07-21 at 14 02 47@2x

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

Copy link

vercel bot commented Jul 21, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Jul 21, 2025 8:04pm
fides-privacy-center ⬜️ Ignored (Inspect) Jul 21, 2025 8:04pm

@lucanovera lucanovera self-requested a review July 21, 2025 20:13
@gilluminate gilluminate merged commit 0e49a87 into main Jul 21, 2025
17 checks passed
@gilluminate gilluminate deleted the gill/debug-logger branch July 21, 2025 20:56
Copy link

cypress bot commented Jul 21, 2025

fides    Run #13142

Run Properties:  status check passed Passed #13142  •  git commit 0e49a87ea8: Debug Logger fixes (#6369)
Project fides
Branch Review main
Run status status check passed Passed #13142
Run duration 00m 51s
Commit git commit 0e49a87ea8: Debug Logger fixes (#6369)
Committer Jason Gill
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 5
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants