Skip to content

Conversation

galvana
Copy link
Contributor

@galvana galvana commented Jul 21, 2025

Closes ENG-988

Description Of Changes

Prevents integrations with more than 50 datasets from unlinking their datasets when saving via the System > Integrations form.

Code Changes

  • Code fix
  • Starting point for "QA scenarios", scripts that are used to get Fides into a specific scenario for manual testing. In this first pass I added a integration_with_many_datasets scenario that automatically creates a System with an integration and 60 linked datasets.

Steps to Confirm

  1. Start Fides and the Admin UI
  2. Run python qa integration_with_many_datasets setup
  3. Navigate to the Integration tab of the newly created system
  4. Verify all 60 datasets are visible in the integration form
  5. Save the form
  6. Verify all 60 datasets are still visible in the integration form
  7. Cleanup the system, integration, and datasets python qa integration_with_many_datasets teardown

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

Copy link

vercel bot commented Jul 21, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Jul 23, 2025 0:06am
fides-privacy-center ⬜️ Ignored (Inspect) Jul 23, 2025 0:06am

Copy link

codecov bot commented Jul 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.59%. Comparing base (387459f) to head (b16cba1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6367   +/-   ##
=======================================
  Coverage   86.58%   86.59%           
=======================================
  Files         452      452           
  Lines       28829    28832    +3     
  Branches     3210     3210           
=======================================
+ Hits        24963    24966    +3     
  Misses       3129     3129           
  Partials      737      737           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@galvana galvana requested a review from thabofletcher July 22, 2025 17:14
@galvana galvana merged commit 39c9f86 into main Jul 23, 2025
24 checks passed
@galvana galvana deleted the ENG-988-support-more-than-50-dataset-configs branch July 23, 2025 00:17
Copy link

cypress bot commented Jul 23, 2025

fides    Run #13150

Run Properties:  status check passed Passed #13150  •  git commit 39c9f86a5e: Adding support for 50+ dataset configs (#6367)
Project fides
Branch Review main
Run status status check passed Passed #13150
Run duration 00m 52s
Commit git commit 39c9f86a5e: Adding support for 50+ dataset configs (#6367)
Committer Adrian Galvan
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 5
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants