-
Notifications
You must be signed in to change notification settings - Fork 85
Adding support for 50+ dataset configs #6367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6367 +/- ##
=======================================
Coverage 86.58% 86.59%
=======================================
Files 452 452
Lines 28829 28832 +3
Branches 3210 3210
=======================================
+ Hits 24963 24966 +3
Misses 3129 3129
Partials 737 737 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
thabofletcher
approved these changes
Jul 22, 2025
fides
|
Project |
fides
|
Branch Review |
main
|
Run status |
|
Run duration | 00m 52s |
Commit |
|
Committer | Adrian Galvan |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
0
|
|
0
|
|
0
|
|
0
|
|
5
|
Upgrade your plan to view test results. | |
View all changes introduced in this branch ↗︎ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes ENG-988
Description Of Changes
Prevents integrations with more than 50 datasets from unlinking their datasets when saving via the
System > Integrations
form.Code Changes
integration_with_many_datasets
scenario that automatically creates a System with an integration and 60 linked datasets.Steps to Confirm
python qa integration_with_many_datasets setup
Integration
tab of the newly created systempython qa integration_with_many_datasets teardown
Pre-Merge Checklist
CHANGELOG.md
updatedmain
downgrade()
migration is correct and works