Adding signature v4 to S3 client #6365
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
galvana
commented
Jul 29, 2025
Comment on lines
+105
to
+106
| s3_config = Config(signature_version="s3v4") | ||
| return session.client("s3", config=s3_config) |
Comment on lines
+832
to
+840
| # Verify old URL fails | ||
| response = requests.get(old_presigned_url, timeout=10) | ||
| assert ( | ||
| response.status_code != 200 | ||
| ), "URL without signature v4 should fail for KMS objects" | ||
| assert ( | ||
| "require AWS Signature Version 4" in response.text | ||
| or response.status_code == 400 | ||
| ) |
There was a problem hiding this comment.
This reproduces the issue from prod before the fix
Comment on lines
+865
to
+870
| # Verify v4 URL works | ||
| response = requests.get(fixed_presigned_url, timeout=10) | ||
| assert ( | ||
| response.status_code == 200 | ||
| ), "URL with signature v4 must work for KMS objects" | ||
| assert response.content == test_content |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6365 +/- ##
=======================================
Coverage 86.97% 86.97%
=======================================
Files 454 454
Lines 28961 28963 +2
Branches 3228 3228
=======================================
+ Hits 25190 25192 +2
Misses 3052 3052
Partials 719 719 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fides
|
||||||||||||||||||||||||||||||
| Project |
fides
|
| Branch Review |
main
|
| Run status |
|
| Run duration | 00m 53s |
| Commit |
|
| Committer | Adrian Galvan |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
5
|
Upgrade your plan to view test results. | |
| View all changes introduced in this branch ↗︎ | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes ENG-1021
Description Of Changes
Adding
signature_version=s3v4to our S3 client to support KMS buckets in S3.Steps to Confirm
test_s3_signature_version_4test. It creates pre-signed URLs with and without the signature version.Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works