Skip to content

Updating External Saas Tests #6363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 28 commits into from
Jul 31, 2025
Merged

Updating External Saas Tests #6363

merged 28 commits into from
Jul 31, 2025

Conversation

Vagoasdf
Copy link
Contributor

@Vagoasdf Vagoasdf commented Jul 21, 2025 •
edited
Loading

Description Of Changes

Fixes CI Problems for SaaS Tests

Code Changes

  • Updating vault dependancy for onePassword on Saas Secrets
  • Fixing up masking on erasure tests

Steps to Confirm

CI Passes Properly.
Saas tests run properly

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@Vagoasdf Vagoasdf requested a review from a team as a code owner July 21, 2025 15:43
@vercel Vercel
Copy link

vercel bot commented Jul 21, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Jul 31, 2025 9:46pm
fides-privacy-center ⬜️ Ignored (Inspect) Jul 31, 2025 9:46pm

@codecov Codecov
Copy link

codecov bot commented Jul 21, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.09%. Comparing base (cd2ac3c) to head (a51e4f8).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6363   +/-   ##
=======================================
  Coverage   87.09%   87.09%           
=======================================
  Files         455      455           
  Lines       29248    29248           
  Branches     3242     3242           
=======================================
  Hits        25475    25475           
  Misses       3047     3047           
  Partials      726      726

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Linker44 Linker44 added the run unsafe ci checks Runs fides-related CI checks that require sensitive credentials label Jul 22, 2025
@Vagoasdf Vagoasdf changed the title Removing vault for one password Updating External Saas Tests Jul 28, 2025
@Vagoasdf Vagoasdf requested a review from Linker44 July 28, 2025 15:57
@galvana galvana mentioned this pull request Jul 30, 2025
Closed
16 tasks
galvana
galvana reviewed Jul 30, 2025
View reviewed changes
CHANGELOG.md Outdated
@@ -51,6 +51,7 @@ Changes can also be flagged with a GitHub label for tracking purposes. The URL o
- Fixed an issue where row selections in Action Center tables did not persist across pages [#6357](https://github.com/ethyca/fides/pull/6357)
- Fixed bug where an error toast appeared in a privacy request page when running Fides OSS [#6364](https://github.com/ethyca/fides/pull/6364)
- Escaping column names with spaces for BigQuery [#6380](https://github.com/ethyca/fides/pull/6380)
- Fixing SaaS Integration tests on CI[#6363](https://github.com/ethyca/fides/pull/6363)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably go under Developer Experience as something like this

- Switching from Vault to 1password for SaaS test credentials [#6363](https://github.com/ethyca/fides/pull/6363)

I don't think fixing tests should go in the change log

galvana
galvana requested changes Jul 30, 2025
View reviewed changes
Copy link
Contributor

@galvana galvana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just asking for a quick fix on the change log, looks good otherwise

@Vagoasdf Vagoasdf requested a review from galvana July 30, 2025 20:27
@galvana galvana merged commit 9f183a7 into main Jul 31, 2025
17 checks passed
@galvana galvana deleted the Removing-Vault-For-OnePassword branch July 31, 2025 21:53
@cypress Cypress
Copy link

cypress bot commented Jul 31, 2025

fides    Run #13198

Run Properties:  status check passed Passed #13198  •  git commit 9f183a7ab5: Updating External Saas Tests (#6363)
Project fides
Branch Review main
Run status status check passed Passed #13198
Run duration 00m 51s
Commit git commit 9f183a7ab5: Updating External Saas Tests (#6363)
Committer Bruno Gutierrez Rios
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 5
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

@Vagoasdf Vagoasdf mentioned this pull request Aug 1, 2025
Merged
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galvana galvana galvana approved these changes

@Linker44 Linker44 Linker44 approved these changes

Assignees
No one assigned
Labels
run unsafe ci checks Runs fides-related CI checks that require sensitive credentials
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Vagoasdf @galvana @Linker44