-
Notifications
You must be signed in to change notification settings - Fork 85
Remove all layout styles (margins) from StatusIndicators #6360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
7b3a241
to
5555a95
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jpople Yeah, I left the |
9994ec8
to
b0468f6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Nice cleanup.
bafe231
to
8549254
Compare
fides
|
Project |
fides
|
Branch Review |
main
|
Run status |
|
Run duration | 00m 58s |
Commit |
|
Committer | Jason Gill |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
0
|
|
0
|
|
0
|
|
0
|
|
5
|
Upgrade your plan to view test results. | |
View all changes introduced in this branch ↗︎ |
Closes ENG-893
Description Of Changes
Removed hard-coded layout styles (margins) from status indicator components and moved spacing responsibility to their wrapper components. Replaced Chakra UI layout components (Box, Flex) with Ant Design Space components as part of the ongoing UI library migration.
Code Changes
mr
,mb
margin props from all status indicator componentsBox
andFlex
layout components withAntSpace as Space
createIcon
with pure SVG componentsSteps to Confirm
Pre-Merge Checklist
CHANGELOG.md
updatedmain
downgrade()
migration is correct and works