Skip to content

Conversation

gilluminate
Copy link
Contributor

@gilluminate gilluminate commented Jul 15, 2025

Closes ENG-934

Description Of Changes

Added ID attributes to consent buttons so that external scripts (eg. web monitor) don't need to rely on class names or data-testid which are less reliable.

Steps to Confirm

  1. Check that button IDs are properly set on all of the footer buttons in the banner and modal for both TCF and non-TCF.

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

Copy link

vercel bot commented Jul 15, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Jul 15, 2025 11:06pm
fides-privacy-center ⬜️ Ignored (Inspect) Jul 15, 2025 11:06pm

@gilluminate gilluminate force-pushed the gill/ENG-934/fides-js-web-monitor-support-2 branch from 6bd69e0 to d1a30a3 Compare July 15, 2025 23:06
@gilluminate gilluminate merged commit a630a40 into main Jul 15, 2025
17 checks passed
@gilluminate gilluminate deleted the gill/ENG-934/fides-js-web-monitor-support-2 branch July 15, 2025 23:10
Copy link

cypress bot commented Jul 15, 2025

fides    Run #13122

Run Properties:  status check passed Passed #13122  •  git commit a630a4032e: Add IDs to FidesJS buttons (#6343)
Project fides
Branch Review main
Run status status check passed Passed #13122
Run duration 00m 51s
Commit git commit a630a4032e: Add IDs to FidesJS buttons (#6343)
Committer Jason Gill
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 5
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants