Skip to content

feat: editable gvl vendors [ENG-844] #6341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jul 17, 2025
Merged

feat: editable gvl vendors [ENG-844] #6341

merged 9 commits into from
Jul 17, 2025

Conversation

speaker-ender
Copy link
Contributor

@speaker-ender speaker-ender commented Jul 15, 2025 •
edited
Loading

Closes ENG-844

Description Of Changes

Allows more system information fields and data uses to be edited if it is a GVL vendor.

Code Changes

  • Updated System Information Form
  • Updated Data Uses Form
  • Removed save functionality from System Information Sidebar
  • Refactored Cyress Tests associated with systems in plus version

Steps to Confirm

  1. Set up your environment to enable TCF and dictionaries.
  2. Create a new system via Compass
  3. Check that the expected fields are either enabled or disabled
  4. Create a system manually
  5. Confirm that the expected fields are enabled or disabled

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel Vercel
Copy link

vercel bot commented Jul 15, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Jul 17, 2025 3:43pm
fides-privacy-center ⬜️ Ignored (Inspect) Jul 17, 2025 3:43pm

@speaker-ender
feat: editable gvl vendors [ENG-844]
d168192 
chore: disable save button

chore: gvl notice update

fix: restore save

fix: correct edit removal and tests

refactor: cypress tests

fix: disabled functionality for gvl

chore: syncing tests with non-gvl vendors

chore: update changelog
@speaker-ender speaker-ender force-pushed the feat/editable-gvl-vendors branch from 4df6760 to d168192 Compare July 15, 2025 19:21
@speaker-ender speaker-ender marked this pull request as ready for review July 15, 2025 19:46
jpople
jpople reviewed Jul 15, 2025
View reviewed changes
Copy link
Contributor

@jpople jpople left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, and thanks for the refactor on the tests. Couple of clarifying questions on AC/functionality but once those are confirmed should be good to merge.

@speaker-ender speaker-ender merged commit f9d248b into main Jul 17, 2025
20 checks passed
@speaker-ender speaker-ender deleted the feat/editable-gvl-vendors branch July 17, 2025 16:01
@cypress Cypress
Copy link

cypress bot commented Jul 17, 2025 •
edited by jira bot
Loading

fides    Run #13131

Run Properties:  status check passed Passed #13131  •  git commit f9d248bbce: feat: editable gvl vendors [ENG-844] (#6341)
Project fides
Branch Review main
Run status status check passed Passed #13131
Run duration 00m 53s
Commit git commit f9d248bbce: feat: editable gvl vendors [ENG-844] (#6341)
Committer 3nder
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 5
View all changes introduced in this branch ↗︎

Kelsey-Ethyca pushed a commit that referenced this pull request Jul 18, 2025
@speaker-ender @Kelsey-Ethyca
feat: editable gvl vendors [ENG-844] (#6341)
8321b77
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpople jpople jpople approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@speaker-ender @jpople