-
Notifications
You must be signed in to change notification settings - Fork 86
[ENG-899] corrected some manual task graph creation issues #6335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENG-899] corrected some manual task graph creation issues #6335
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (45.45%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #6335 +/- ##
==========================================
+ Coverage 86.76% 86.78% +0.01%
==========================================
Files 448 448
Lines 28612 28603 -9
Branches 3180 3177 -3
==========================================
- Hits 24826 24822 -4
+ Misses 3050 3048 -2
+ Partials 736 733 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
🚀 🚀 🚀 |
fides
|
Project |
fides
|
Branch Review |
main
|
Run status |
|
Run duration | 00m 50s |
Commit |
|
Committer | JadeWibbels |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
0
|
|
0
|
|
0
|
|
0
|
|
5
|
View all changes introduced in this branch ↗︎ |
Closes #ENG-899
Description Of Changes
Discovered an error where skipping/completing some manual tasks was causing the request to hang. This PR addresses that issue.
Code Changes
Steps to Confirm
config_id | man_9ed7fa90-e5b5-4a50-b1df-65f64243ee03 != config_id | man_05147435-c5f1-4d14-874c-d5ab4226b61c
The access config:
The erasure config
Pre-Merge Checklist
CHANGELOG.md
updatedmain
downgrade()
migration is correct and works