Skip to content

Conversation

gilluminate
Copy link
Contributor

Upgrades RollupJS to latest version.

  • I've read through their migration docs and all of the potential issues called out are with features we do not use.
  • Tests all pass and no issues spotted in manual testing.
  • Trims ~0.7k from each of our build sizes!

Copy link

vercel bot commented Jul 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Jul 11, 2025 6:51pm
fides-privacy-center ⬜️ Ignored (Inspect) Jul 11, 2025 6:51pm

Copy link
Contributor

@eastandwestwind eastandwestwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just 1 Q for completeness

@@ -83,7 +82,7 @@
"jest-environment-jsdom": "^29.7.0",
"postcss": "^8.4.31",
"prettier": "^3.3.3",
"rollup": "^3.29.5",
"rollup": "^4.44.2",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a follow-up to upgrade rollup version in Fidesplus as well? https://github.com/ethyca/fidesplus/blob/main/clients/fides-js-extensions/nytimes/package.json#L31

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great suggestion, I'll create one!

@gilluminate gilluminate merged commit a29d360 into main Jul 14, 2025
17 checks passed
@gilluminate gilluminate deleted the gill/upgrade-rollup branch July 14, 2025 14:56
Copy link

cypress bot commented Jul 14, 2025

fides    Run #13114

Run Properties:  status check passed Passed #13114  •  git commit a29d3600ba: Upgrade RollupJS to latest (#6330)
Project fides
Branch Review main
Run status status check passed Passed #13114
Run duration 00m 52s
Commit git commit a29d3600ba: Upgrade RollupJS to latest (#6330)
Committer Jason Gill
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 5
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants