-
Notifications
You must be signed in to change notification settings - Fork 85
ENG-898 #6319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
thabofletcher
approved these changes
Jul 10, 2025
Looks good! 🚀 Worked as best I could test it, thanks for the steps to help with that - I did most of my testing by just modifying the custom_asset.py in fideplus |
fides
|
Project |
fides
|
Branch Review |
main
|
Run status |
|
Run duration | 00m 50s |
Commit |
|
Committer | Tom Van Dort |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
0
|
|
0
|
|
0
|
|
0
|
|
5
|
View all changes introduced in this branch ↗︎ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes ENG-898
Description Of Changes
Retry for pulling
custom-fides.css
on failures.Do not disable
custom-fides.css
polling on failures that are not 404.Code Changes
Steps to Confirm
404 Behavior shuts off polling & Retry does not occur
api/v1/custom-asset/custom-fides.css
uploaded.https://localhost:3001/fides.js
twiceapi/v1/custom-asset/custom-fides.css
is only called once by looking at the server logs.FIDES_PRIVACY_CENTER__LOG_LEVEL=debug
to see attempt messages.Non-404 Behavior will retry and leave CSS polling on
src/fidesplus/api/routes/custom_asset.py
to return a 500https://localhost:3001/fides.js
api/v1/custom-asset/custom-fides.css
is called multiple times via Fides API & Privacy Center logshttps://localhost:3001/fides.js
, observe the same things from step 4 indicating that CSS polling is enabled still200 behavior is maintained
api/v1/custom-asset/custom-fides.css
https://localhost:3001/fides.js
twiceapi/v1/custom-asset/custom-fides.css
is called oncePre-Merge Checklist
CHANGELOG.md
updatedmain
downgrade()
migration is correct and works