Skip to content

Conversation

lucanovera
Copy link
Contributor

@lucanovera lucanovera commented Jul 8, 2025

Description Of Changes

Changes the default filter in Manual Tasks to be the current logged in user. Other improvements.

Code Changes

  • Adds default filters
  • Unify into a single source of truth for the privacy request id filter
  • Improve styling for active filter button in Ant's columns

Steps to Confirm

  1. Visit preview at https://fides-plus-nightly-git-tasks-table-assigned-user-33beee-ethyca.vercel.app/
  2. Login using fidesroot (1pass) and go to Privacy Requests > Request manager > Manual tasks
  3. Check the default view for the table is to see the Assigned to filter applied (the button has a dark gray background and the icon is dark too) to the user "fidesroot".
  4. The table should show no results and this message "You have no tasks assigned. You can modify the "Assigned to" column filter to view tasks assigned to other users.".
  5. Check that you can change the filter to see other user's tasks
  6. Logout
  7. Login using Contributor user (1pass)
  8. Go to Privacy Requests > Request manager > Manual tasks
  9. You should see the table being filter only by contributor's tasks
  10. Check that you can change the filter to see other user's tasks
  11. Filter by "test approver" user and type "Access", you should see the generic empty table message ("No results found.
    ").
  12. Go to the "Request" tab and click on any of the recent privacy requests
  13. Go to the Manual Tasks tab of the privacy request details
  14. Click on View all tasks for this request
  15. Check the table shows all the tasks related to the request and doesn't apply any filter regarding the user

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

Copy link

vercel bot commented Jul 8, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Jul 10, 2025 9:36pm
fides-privacy-center ⬜️ Ignored (Inspect) Jul 10, 2025 9:36pm

@lucanovera lucanovera changed the title Tasks table assigned user improvements ENG-907 Tasks table assigned user improvements Jul 8, 2025
Copy link
Contributor

@JadeCara JadeCara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went through all the manual test steps. Looks good!

@lucanovera lucanovera merged commit 55ee592 into main Jul 10, 2025
20 checks passed
@lucanovera lucanovera deleted the tasks-table-assigned-user-improvements branch July 10, 2025 21:42
Copy link

cypress bot commented Jul 10, 2025

fides    Run #13103

Run Properties:  status check passed Passed #13103  •  git commit 55ee59262f: ENG-907 Tasks table assigned user improvements (#6317)
Project fides
Branch Review main
Run status status check passed Passed #13103
Run duration 00m 51s
Commit git commit 55ee59262f: ENG-907 Tasks table assigned user improvements (#6317)
Committer Lucano Vera
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 5
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants