Skip to content

Conversation

lucanovera
Copy link
Contributor

@lucanovera lucanovera commented Jul 8, 2025

Description Of Changes

Make external task ui allow only a single value for every column filtering (api only supports that). Remove unnecessary param to complete action for consistency with admin-ui. Fix skip task.

Code Changes

  • use filterMultiple false option in the column filtering
  • update filtering code
  • remove unnecessary field key param
  • update pagination sizes to match admin-ui
  • fix auth layout

Steps to Confirm

  1. list any manual steps for reviewers to confirm the changes

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

Copy link

vercel bot commented Jul 8, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Jul 8, 2025 0:46am
fides-privacy-center ⬜️ Ignored (Inspect) Jul 8, 2025 0:46am

Copy link
Contributor

@JadeCara JadeCara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lucanovera lucanovera merged commit 2ebac76 into main Jul 8, 2025
21 checks passed
@lucanovera lucanovera deleted the fix-external-ui-bugs branch July 8, 2025 01:25
lucanovera added a commit that referenced this pull request Jul 8, 2025
Copy link

cypress bot commented Jul 8, 2025

fides    Run #13085

Run Properties:  status check passed Passed #13085  •  git commit 2ebac76b9b: Fix external UI bugs (#6313)
Project fides
Branch Review main
Run status status check passed Passed #13085
Run duration 00m 51s
Commit git commit 2ebac76b9b: Fix external UI bugs (#6313)
Committer Lucano Vera
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 5
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants