Skip to content

Conversation

gilluminate
Copy link
Contributor

@gilluminate gilluminate commented Jun 30, 2025

Closes ENG-753

Description Of Changes

Adds consent status to the Action Center. This introduces a "Discovery" column to the assets table, which indicates whether an asset was found with or without consent. A warning icon now appears next to monitors that have assets detected without consent. Users can click the status badge for an asset to open a modal that shows the specific locations and pages where the asset was found without consent.

Code Changes

  • API: Added a new getConsentBreakdown endpoint to fetch the locations and pages for a given asset and consent status.
  • Monitors List: Updated the monitors list in the Action Center to display a warning icon next to any monitor that has assets detected without consent.
  • Discovered Assets Table:
    • Added a new "Discovery" column to show the consent status of each asset (e.g., "With Consent," "Without Consent").
    • Assets are now sorted by default to show those "Without Consent" first.
    • Clicking the "Without Consent" badge info icon opens a new ConsentBreakdownModal.
  • ConsentBreakdownModal: Created a new modal to display a paginated table of locations and pages where an asset was detected without consent. (Pagination only appears if there are more than 25 items)
  • DiscoveryStatusIcon: Created a new reusable component to consistently display the warning icon and tooltip for consent issues.

Steps to Confirm

  1. Navigate to the Action Center in the Admin UI.
  2. Observe the list of monitors. If any monitor has detected assets without consent, a red alert icon should appear next to its name.
  3. Click on a monitor with consent issues.
  4. Observe the list of Systems. If any system has detected assets without consent, a red alert icon should appear next to its name.
  5. Click on a System with consent issues.
  6. On the "Discovered Assets" table, you should see a "Discovery" column.
  7. Assets should be sorted with "Without consent" statuses appearing first.
  8. Click on a "Without consent" status badge info icon for any asset.
  9. A "Consent discovery" modal should open, showing a table of "Location" and "Page" where the asset was detected.

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

Copy link

vercel bot commented Jun 30, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 14, 2025 7:51pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-privacy-center ⬜️ Ignored (Inspect) Jul 14, 2025 7:51pm

Copy link
Contributor

@speaker-ender speaker-ender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly minor comments or questions.
i can approve if you don't have any concerns around my comments.

Copy link
Contributor

@speaker-ender speaker-ender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@gilluminate gilluminate force-pushed the gill/ENG-753/fe-show-consent-status branch from d6cca2a to bb656e8 Compare July 14, 2025 19:47
@gilluminate gilluminate merged commit ed6630e into main Jul 14, 2025
20 checks passed
@gilluminate gilluminate deleted the gill/ENG-753/fe-show-consent-status branch July 14, 2025 21:10
Copy link

cypress bot commented Jul 14, 2025

fides    Run #13117

Run Properties:  status check passed Passed #13117  •  git commit ed6630ed42: Show consent status on assets and vendors (#6283)
Project fides
Branch Review main
Run status status check passed Passed #13117
Run duration 00m 50s
Commit git commit ed6630ed42: Show consent status on assets and vendors (#6283)
Committer Jason Gill
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 5
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants