-
Notifications
You must be signed in to change notification settings - Fork 86
Show consent status on assets and vendors #6283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
5f7a9c4
to
600b29b
Compare
bccc92a
to
7a3d8fb
Compare
7a3d8fb
to
d8c4a17
Compare
d8c4a17
to
f586283
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mostly minor comments or questions.
i can approve if you don't have any concerns around my comments.
...eatures/data-discovery-and-detection/action-center/tables/cells/DiscoveryStatusBadgeCell.tsx
Outdated
Show resolved
Hide resolved
...eatures/data-discovery-and-detection/action-center/tables/cells/DiscoveryStatusBadgeCell.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
a20ce37
to
10e8e89
Compare
10e8e89
to
ca7a417
Compare
ca7a417
to
69d0902
Compare
5fd2f42
to
7b3d9c1
Compare
This works since default ordering is by status, so first page's first items will always give is the correct status for the header
d6cca2a
to
bb656e8
Compare
fides
|
Project |
fides
|
Branch Review |
main
|
Run status |
|
Run duration | 00m 50s |
Commit |
|
Committer | Jason Gill |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
0
|
|
0
|
|
0
|
|
0
|
|
5
|
View all changes introduced in this branch ↗︎ |
Closes ENG-753
Description Of Changes
Adds consent status to the Action Center. This introduces a "Discovery" column to the assets table, which indicates whether an asset was found with or without consent. A warning icon now appears next to monitors that have assets detected without consent. Users can click the status badge for an asset to open a modal that shows the specific locations and pages where the asset was found without consent.
Code Changes
getConsentBreakdown
endpoint to fetch the locations and pages for a given asset and consent status.ConsentBreakdownModal
.ConsentBreakdownModal
: Created a new modal to display a paginated table of locations and pages where an asset was detected without consent. (Pagination only appears if there are more than 25 items)DiscoveryStatusIcon
: Created a new reusable component to consistently display the warning icon and tooltip for consent issues.Steps to Confirm
Pre-Merge Checklist
CHANGELOG.md
updatedmain
downgrade()
migration is correct and works