fix: location select mode and table display [ENG-1305] #6545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
195893a to
b8c9f28
Compare
fix: region rendering chore: revert table changes chore: update changelog chore: fix liniting
23b207c to
079ce1e
Compare
erosselli
approved these changes
Sep 4, 2025
Comment on lines
-207
to
+213
| const params = row.datasource_params as WebsiteMonitorParams | null; | ||
| const locations = | ||
| row.datasource_params && | ||
| "locations" in row.datasource_params && | ||
| Array.isArray(row.datasource_params.locations) | ||
| ? row.datasource_params.locations | ||
| : []; |
There was a problem hiding this comment.
don't we want to keep the cast to WebsiteMonitorParams to avoid all the checking "locations" in row.datasource_params , Array.isArray etc ?
There was a problem hiding this comment.
Casting without checks could lead to a bug since we have no assurances that it's accurate.
The real fix is having the correct type for the table/response from the api that includes location in the type.
Comment on lines
224
to
226
| const regionRecord = | ||
| regionCode && PRIVACY_NOTICE_REGION_RECORD[regionCode[1]]; | ||
|
|
There was a problem hiding this comment.
what's regionCode[1] here? maybe that warrants a code comment :)
There was a problem hiding this comment.
Yes it's def unclear.
These values are fallbacks that should be depreciated and will make note of it.
eastandwestwind
pushed a commit
that referenced
this pull request
Sep 4, 2025
fides
|
||||||||||||||||||||||||||||
| Project |
fides
|
| Branch Review |
main
|
| Run status |
|
| Run duration | 00m 58s |
| Commit |
|
| Committer | 3nder |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
5
|
| View all changes introduced in this branch ↗︎ | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes ENG-1305
Description Of Changes
Fixing location select props and display within table
Code Changes
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works