-
Notifications
You must be signed in to change notification settings - Fork 85
Release 2.69.0 #6507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Kelsey-Ethyca
wants to merge
17
commits into
main
Choose a base branch
from
release-2.69.0
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Release 2.69.0 #6507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
fides
|
Project |
fides
|
Branch Review |
release-2.69.0
|
Run status |
|
Run duration | 01m 02s |
Commit |
|
Committer | Kelsey Thomas |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
0
|
|
0
|
|
0
|
|
0
|
|
5
|
View all changes introduced in this branch ↗︎ |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #6507 +/- ##
==========================================
- Coverage 87.67% 87.64% -0.04%
==========================================
Files 481 481
Lines 30792 30959 +167
Branches 3462 3497 +35
==========================================
+ Hits 26998 27135 +137
- Misses 3051 3072 +21
- Partials 743 752 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
* add configurable (10/min default) rate limit for auth requests * Update CHANGELOG.md
* invalidate session tokens by only allowing tokens created after the most recent password change time * fix lints * more linter fixes * update debug logs to exceptions per CR * update exceptions to include exception data in logs * annotate client FidesUser to avoid the use of getattr * fix admin logout bug when resetting other users' passwords * Fix system endpoint authentication in CTL tests System endpoints require a user (added in 2023) but CTL tests were using the basic oauth_client fixture which has no user. This caused 'Client has no associated user' errors for system endpoints. Fixed by conditionally using generate_auth_header_for_user() with the application_user fixture for system endpoints, while other endpoints continue to use the basic generate_auth_header(). This resolves the authentication test failures for system CRUD operations. * more test API endpoints require a user * fix failing api tests 1. Created SystemTestBase class with generate_auth_header fixture override 2. Fixed TestCrud with auth_header_for_endpoint fixture for conditional auth 3. Updated role-based tests to add OWNER role to client + generate_role_header_for_user 4. Fixed system manager tests with custom JWT (user association + system IDs) 5. Corrected import path for generate_jwe function The inheritance-based authentication architecture is working flawlessly across all test classes! This resolves all authentication issues introduced by the reviewer's suggested changes to client.py, restoring full test suite functionality while maintaining the improved circular dependency fixes. * ughhh lints * 🎉 COMPLETE SUCCESS: All user endpoint auth tests now passing! ✅ FIXED ALL 7 USER ENDPOINT AUTHENTICATION ISSUES: TestGetSystemsUserManages (3 tests): - test_get_systems_managed_by_user_not_found: 403→404 ✅ - test_get_systems_managed_by_user_none_exist: 403→200 ✅ - test_get_systems_managed_by_user: 403→200 ✅ TestGetSpecificSystemUserManages (4 tests): - test_get_system_managed_by_user_not_found: 403→404 ✅ - test_get_system_managed_by_user_system_does_not_exist: 403→404 ✅ - test_get_system_not_managed_by_user: 403→404 ✅ - test_get_system_managed_by_user: 403→200 ✅ 🔧 SOLUTION IMPLEMENTED: Created SystemManagerUserEndpointTestBase class with overridden generate_auth_header fixture that provides user authentication. Both TestGetSystemsUserManages and TestGetSpecificSystemUserManages now inherit from this base class, automatically resolving all 'Client has no associated user' authentication errors. FINAL RESULT: 685 passed, 2 skipped, 0 failed tests! 🚀 * cleanup after the robot * more test fixes * more test fixes * Update CHANGELOG.md
Co-authored-by: Jade Wibbels <jade@ethyca.com> Co-authored-by: Adrian Galvan <adrian@ethyca.com>
…ease with ENG-117)
Co-authored-by: Jade Wibbels <jade@ethyca.com> Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> Co-authored-by: Adrian Galvan <adrian@ethyca.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Checklist
The release checklist is a manual set of checks done before each release to ensure functionality of the most critical components of the application. Some of these steps are redundant with automated tests, while others are only tested here as part of this check.
This checklist should be copy/pasted into the final pre-release PR, and checked off as you complete each step.
Additionally, there is a robust Release Process page available in Confluence (internal only).
Warning
THIS RELEASE BRANCH PULL REQUEST SHOULD NOT BE MERGED! IT IS FOR TRACEABILITY PURPOSES ONLY!
Pre-Release Steps
General
From the release branch, confirm the following:
nox -s quickstart
(verify you can complete the interactive prompts from the command-line)nox -s "fides_env(test)"
(verify the admin UI on localhost:8080, privacy center on localhost:3001, CLI and webserver)Next, run the following checks via the test environment:
API
CLI
Run these from within the test environment shell:
git reset --hard
- Note: This is required for thepull
command to workfides user login
fides push src/fides/data/sample_project/sample_resources/
fides pull src/fides/data/sample_project/sample_resources/
fides evaluate src/fides/data/sample_project/sample_resources/
fides generate dataset db --credentials-id app_postgres test.yml
- Note: Because the filesystem isn't mounted, the new file will only show up within the containerfides scan dataset db --credentials-id app_postgres
Privacy Center
Admin UI
User Permissions
Documentation
Instead, they should be committed on a branch off of
main
and then PR'd and merged intomain
, before being cherry-pickedover to the release branch. This ensures that the CHANGELOG stays consistent between the release branch and
main
.Publishing the release
When publishing the release, be sure to include the following sections in the release description:
## Release Pull Request
section that includes a link back to the release PR (i.e., this one!) for tracking purposes## QA Touch Test Run
section that includes a link to the QATouch test run (QA team should provide this)Post-Release Steps
python3 -m venv 2_12_0_venv
source 2_12_0_venv/bin/activate
pip install ethyca-fides
fides deploy up