Skip to content

ENG-1209 - Add logs to debug detection task #6482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 21, 2025
Merged

ENG-1209 - Add logs to debug detection task #6482

merged 1 commit into from
Aug 21, 2025

Conversation

vcruces
Copy link
Contributor

@vcruces vcruces commented Aug 21, 2025 •
edited
Loading

https://ethyca.atlassian.net/browse/ENG-1209

Description Of Changes

Add logs to help debug the performance of the detection task.

Code Changes

  • Add debug logs

Steps to Confirm

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel Vercel
Copy link

vercel bot commented Aug 21, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
fides-plus-nightly Ignored Ignored Preview Aug 21, 2025 6:46pm
fides-privacy-center Ignored Ignored Aug 21, 2025 6:46pm

@vcruces vcruces marked this pull request as ready for review August 21, 2025 18:45
@vcruces vcruces requested a review from adamsachs August 21, 2025 18:46
adamsachs
adamsachs approved these changes Aug 21, 2025
View reviewed changes
Copy link
Contributor

@adamsachs adamsachs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov Codecov
Copy link

codecov bot commented Aug 21, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.61%. Comparing base (f400efd) to head (c5aefc4).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6482   +/-   ##
=======================================
  Coverage   87.61%   87.61%           
=======================================
  Files         466      466           
  Lines       29781    29783    +2     
  Branches     3310     3310           
=======================================
+ Hits        26092    26094    +2     
  Misses       2980     2980           
  Partials      709      709

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vcruces vcruces merged commit 1682fef into main Aug 21, 2025
46 checks passed
@vcruces vcruces deleted the ENG-1209-logs branch August 21, 2025 19:33
@cypress Cypress
Copy link

cypress bot commented Aug 21, 2025

fides    Run #13256

Run Properties:  status check passed Passed #13256  •  git commit 1682fef0ef: ENG-1209 - Add logs to debug detection task (#6482)
Project fides
Branch Review main
Run status status check passed Passed #13256
Run duration 00m 53s
Commit git commit 1682fef0ef: ENG-1209 - Add logs to debug detection task (#6482)
Committer Victoria Cruces
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 5
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamsachs adamsachs adamsachs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vcruces @adamsachs