-
Notifications
You must be signed in to change notification settings - Fork 86
Updated the privacy request service to also check for awaitng input status #6471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated the privacy request service to also check for awaitng input status #6471
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6471 +/- ##
=======================================
Coverage 87.61% 87.61%
=======================================
Files 459 459
Lines 29491 29494 +3
Branches 3279 3280 +1
=======================================
+ Hits 25838 25841 +3
Misses 2948 2948
Partials 705 705 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment @cursor review
or bugbot run
to trigger another review on this PR
fides
|
Project |
fides
|
Branch Review |
main
|
Run status |
|
Run duration | 00m 49s |
Commit |
|
Committer | JadeWibbels |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
0
|
|
0
|
|
0
|
|
0
|
|
5
|
View all changes introduced in this branch ↗︎ |
Closes []
Description Of Changes
Current Problem (Without Fix)
Privacy request gets stuck in requires_input status and has to wait for theTask graph to eventually time out to see the error message.
Proposed Fix
Added the requires input status to the request runner check.
Normal queue checkers pick up the request again with the manual task is complete, so the request can proceed normally.
If there are still other errors, they'll be handled by the normal error handling flow.
When they pick up a request that was previously stuck:
Some Different Scenarios
Scenario 1: Manual Task Was the Only Issue
✅ Problem solved
Scenario 2: There Are Still Other Errors
✅ Proper error handling restored
Scenario 3: Manual Task Wasn't Actually Complete
✅ Self-correcting behavior
Code Changes
Steps to Confirm
data/dataset/postgres_example_test_dataset.yml
Pre-Merge Checklist
CHANGELOG.md
updatedmain
downgrade()
migration is correct and works