Skip to content

Conversation

JadeCara
Copy link
Contributor

@JadeCara JadeCara commented Aug 18, 2025

Closes []

Description Of Changes

Current Problem (Without Fix)

Privacy request gets stuck in requires_input status and has to wait for theTask graph to eventually time out to see the error message.

Proposed Fix

Added the requires input status to the request runner check.
Normal queue checkers pick up the request again with the manual task is complete, so the request can proceed normally.
If there are still other errors, they'll be handled by the normal error handling flow.

When they pick up a request that was previously stuck:

  • First Check: They'll see the manual task is now complete (because we just completed it)
  • Normal Flow: The request continues through the normal task execution
  • Error Handling: If there are still other issues, they'll be caught and handled properly

Some Different Scenarios
Scenario 1: Manual Task Was the Only Issue

  • status in awaiting input
  • Queue checker picks it up
  • Request completes successfully (no more errors)
    ✅ Problem solved

Scenario 2: There Are Still Other Errors

  • status in awaiting input
  • Queue checker picks it up
  • Other errors are encountered and handled normally
  • Request might go back to requires_input or error status as appropriate
    ✅ Proper error handling restored

Scenario 3: Manual Task Wasn't Actually Complete

  • Status in awaiting input
  • Queue checker picks it up
  • _run_request detects incomplete manual task
  • Raises AwaitingAsyncTaskCallback again
  • Request goes back to requires_input status
    ✅ Self-correcting behavior

Code Changes

  • Added a small update to how access tasks are handled for erasures.
  • Updated the request runner to look at awaiting input statuses
  • added some tests

Steps to Confirm

  1. Add the data/dataset/postgres_example_test_dataset.yml
  2. Run fidesplus pointed at this branch.
  3. stop the postgres container.
  4. Create an Access DSR - verify it errors correctly
  5. Create and Erasure DSR - verify it errors correctly.
Screenshot 2025-08-18 at 10 33 22 AM Screenshot 2025-08-18 at 10 33 14 AM Screenshot 2025-08-18 at 10 32 27 AM 6. Turn back on the postgres container 7. Re rerun the DSRs 8. Verify they both run as expected.

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

Copy link

vercel bot commented Aug 18, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
fides-plus-nightly Ignored Ignored Preview Aug 18, 2025 6:10pm
fides-privacy-center Ignored Ignored Aug 18, 2025 6:10pm

@JadeCara JadeCara changed the base branch from main to release-2.68.0 August 18, 2025 17:28
@JadeCara JadeCara marked this pull request as ready for review August 18, 2025 17:32
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment @cursor review or bugbot run to trigger another review on this PR

@JadeCara JadeCara changed the title 1subtle dsr processing issue subtle dsr processing issue Aug 18, 2025
Copy link

codecov bot commented Aug 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.39%. Comparing base (74ba719) to head (4de89ff).
⚠️ Report is 1 commits behind head on release-2.68.0.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-2.68.0    #6469   +/-   ##
===============================================
  Coverage           87.39%   87.39%           
===============================================
  Files                 457      457           
  Lines               29294    29298    +4     
  Branches             3246     3247    +1     
===============================================
+ Hits                25602    25606    +4     
  Misses               2983     2983           
  Partials              709      709           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JadeCara JadeCara merged commit cecd326 into release-2.68.0 Aug 18, 2025
42 checks passed
@JadeCara JadeCara deleted the 1subtle_dsr_processing_issue branch August 18, 2025 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants