Filtering and sorting for discovered assets in Action Center #6401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
gilluminate
commented
Jul 29, 2025
| @@ -5,8 +5,7 @@ import { | |||
| Page_ConsentReportingSchema_, | |||
| PreferencesSavedExtended, | |||
| } from "~/types/api"; | |||
| import { DateRange } from "~/types/common/DateRange"; | |||
| import { PaginationQueryParams } from "~/types/common/PaginationQueryParams"; | |||
| import { DateRangeParams, PaginationQueryParams } from "~/types/query-params"; | |||
There was a problem hiding this comment.
I ended up consolidating all of the various "Params" files in to one query-params.d.ts file. Many of these updates like this are just updating that and you can just gloss over them.
| @@ -1,4 +1,4 @@ | |||
| import { formatDistance } from "date-fns"; | |||
| import { formatDistanceStrict } from "date-fns"; | |||
There was a problem hiding this comment.
this removes the "about..." prefix, etc for a cleaner column.
| @@ -105,14 +106,12 @@ export const MonitorResult = ({ | |||
| </Col> | |||
| <Col span={3} className="flex items-center justify-end"> | |||
| {!!lastMonitoredDistance && ( | |||
| <Tooltip title={formattedLastMonitored}> | |||
There was a problem hiding this comment.
redundant tooltip clean up here
| React.Children.count(props.children) === 1 && | ||
| React.isValidElement(props.children) && | ||
| typeof props.children.type === "object"; | ||
| const WrappedTag = React.forwardRef<HTMLElement, CustomTagProps>( |
There was a problem hiding this comment.
This line is the only real change here. Addressing some console errors that complained about lack of forwardRef on these components.
| CustomTypographyTextProps) => ( | ||
| <Typography.Link className={getTextSizeClassName(size)} {...props} /> | ||
| ); | ||
| const CustomLink = React.forwardRef< |
There was a problem hiding this comment.
same here, just adding the forwardRef
1abc68f to
5bc6eb9
Compare
speaker-ender
approved these changes
Jul 30, 2025
speaker-ender
approved these changes
Jul 30, 2025
e6de0a5 to
b398184
Compare
gilluminate
added a commit
that referenced
this pull request
Jul 30, 2025
fides
|
||||||||||||||||||||||||||||||
| Project |
fides
|
| Branch Review |
main
|
| Run status |
|
| Run duration | 00m 55s |
| Commit |
|
| Committer | Jason Gill |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
5
|
Upgrade your plan to view test results. | |
| View all changes introduced in this branch ↗︎ | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes ENG-237
Description Of Changes
Added filtering capabilities to the discovered assets table in the action center, allowing users to filter by resource type, data uses, locations, and consent status. Improved query parameter handling with new utility functions and enhanced API endpoints to support the filtering functionality. Also improved time display formatting and fixed UI interaction issues.
Code Changes
buildArrayQueryParamsutility function to handle array-based URL query parametersconvertToAntFiltersutility function to transform arrays into Ant Design filter objectsgetWebsiteMonitorResourceFiltersAPI endpoint to fetch available filter optionsgetDiscoveredAssetsAPI query to support filtering by resource type, data uses, locations, and consent statusDiscoveredAssetsColumnKeysenumMonitorResultcomponent usingformatDistanceStrictfor more precise formattingMenuHeaderCellcomponentanyto specific types (string,Schema)Steps to Confirm
Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works