Setup signing for macOS app #1368
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds code signing support for macOS builds in the GitHub Actions release workflow. The changes enable automatic signing of the macOS application using Apple developer certificates stored as GitHub secrets.
- Imports Apple developer certificate and configures macOS keychain for code signing
- Extracts certificate identity and sets it as environment variable for Tauri build
- Passes required signing credentials to the Tauri action for automated app signing
| APPLE_CERTIFICATE_PASSWORD: ${{ secrets.APPLE_CERTIFICATE_PASSWORD }} | ||
| KEYCHAIN_PASSWORD: ${{ secrets.APPLE_KEYCHAIN_PASSWORD }} | ||
| run: | | ||
| echo $APPLE_CERTIFICATE | base64 --decode > certificate.p12 |
There was a problem hiding this comment.
The certificate file is created in the current directory and not cleaned up after use. Consider creating it in a temporary location and ensuring it's removed after import to avoid potential exposure of sensitive certificate data.
Suggested change
| echo $APPLE_CERTIFICATE | base64 --decode > certificate.p12 | |
| CERTIFICATE_FILE=$(mktemp) | |
| echo $APPLE_CERTIFICATE | base64 --decode > "$CERTIFICATE_FILE" |
Copilot uses AI. Check for mistakes.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.