Fix fast mode initial rendering #1364
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where the fast mode toggle was rendering with a false default value before settings were loaded, causing unintended submissions that prevented the setting from persisting across application restarts.
- Replaces manual form handling with an AutoSubmitSwitch component
- Adds a loading check to prevent rendering until settings are available
- Removes unnecessary form validation and watch logic
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| gui/src/store/useSettings.ts | Adds debug logging for fastMode reloading |
| gui/src/components/QuickFastModeToggle.tsx | Refactors to use AutoSubmitSwitch and prevents premature rendering |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fast mode would initially render to false, and would trigger a submission with that value, resulting in the value not persisting across restarts