feat(fill): Disable --generate-all-formats
for static tests
#1998
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
This PR does two things:
--generate-all-formats
automatic generation if--fill-static-tests
is passed to the command: Currently, there's still a ton of untagged static tests, which means they use hard-coded addresses and therefore have to be put in different groups to disallow collisions, and this results in 71% of tests being placed in different groups, which makes pre-alloc grouping not worth it.pytest.mark.pre_alloc_group
mark to all untagged static tests, in order to, if we decide to fill static tests with pre-alloc grouping, the fill won't fail and we ensure these tests all have their own pre-alloc group.🔗 Related Issues or PRs
N/A.
✅ Checklist
tox
checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx --with=tox-uv tox -e lint,typecheck,spellcheck,markdownlint
type(scope):
.