Skip to content

Conversation

marioevz
Copy link
Member

@marioevz marioevz commented Aug 6, 2025

🗒️ Description

This PR does two things:

  • Disables --generate-all-formats automatic generation if --fill-static-tests is passed to the command: Currently, there's still a ton of untagged static tests, which means they use hard-coded addresses and therefore have to be put in different groups to disallow collisions, and this results in 71% of tests being placed in different groups, which makes pre-alloc grouping not worth it.
  • Adds the pytest.mark.pre_alloc_group mark to all untagged static tests, in order to, if we decide to fill static tests with pre-alloc grouping, the fill won't fail and we ensure these tests all have their own pre-alloc group.

🔗 Related Issues or PRs

N/A.

✅ Checklist

  • All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    uvx --with=tox-uv tox -e lint,typecheck,spellcheck,markdownlint
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered adding an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).

@marioevz marioevz requested a review from fselmo August 6, 2025 18:47
@marioevz marioevz mentioned this pull request Aug 6, 2025
6 tasks
Copy link
Contributor

@spencer-tb spencer-tb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marioevz marioevz merged commit 666cd64 into main Aug 6, 2025
15 checks passed
@marioevz marioevz deleted the disable-all-formats-for-static-tests branch August 6, 2025 20:48
@fselmo
Copy link
Collaborator

fselmo commented Aug 6, 2025

A little late here but saw the review request. Lgtm 👍🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants