feat(tests): EIP-6110 DepositEvent layout+topic tests
#1371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DepositEvent layout+topic tests
8 tasks
33 tasks
11 tasks
17 tasks
holgerd77
reviewed
Apr 15, 2025
marioevz
reviewed
Apr 16, 2025
There was a problem hiding this comment.
Thanks for these!
I think it looks pretty good overall, and just some minor linting issues to get to calm down ruff and mypy :)
If you need help with anything please just ping me and I can help out, but basically once we fix the comments we should be able to go ahead and merge 👍
71b9c65 to
75391a6
Compare
Co-authored-by: Mario Vega <marioevz@gmail.com>
Co-authored-by: Mario Vega <marioevz@gmail.com>
Co-authored-by: Mario Vega <marioevz@gmail.com>
Co-authored-by: Mario Vega <marioevz@gmail.com>
Co-authored-by: Mario Vega <marioevz@gmail.com>
Co-authored-by: Mario Vega <marioevz@gmail.com>
ca41b73 to
4f5cc55
Compare
|
CI passes, ready for review! NOTE: the current tests will check for the "failed transaction error" for the invalid deposit logs. This will fail on client implementations which check the deposit contract logs after ALL transactions (EthJS) and not after EACH transaction (EELS). Any client which has this bug likely implements it the "EthJS" way and is therefore not suitable to fill the tests. Note that EIP-6110 specs parsing the deposit logs after all transactions, not after each transaction. |
marioevz
approved these changes
Apr 16, 2025
pacrob
pushed a commit
to pacrob/execution-spec-tests
that referenced
this pull request
May 5, 2025
* new(tests): Add EIP-6110 Sepolia Variant Contract test * fix(tests): Log code * fix(tests): Log code * fix: ABI encoding optional * fix: parametrize for ABI (No-ABI test disabled) * fix(docs): add docs to helper * fix(tests): lint modified_contract (?) * feat(tests): add DEPOSIT_EVENT_SIGNATURE_HASH EIP-6110 * tmp: add sepolia deposit log data * change test and helper methods * convert back to little-endian encoding * feat(helpers): add helper method to construct modified deposit logs * feat(tests): use new helper in modified contract tests * update test modified contract * fix test filler to produce the correct requests hash * feat(tests): add EIP6110 invalid event layout tests * feat(tests): add exception to transaction * cleanup(tests): use DEFAULTs where appropriate * feat(tests): add invalid log length test * chore(tests) lint * Update tests/prague/eip6110_deposits/helpers.py Co-authored-by: Mario Vega <marioevz@gmail.com> * Update tests/prague/eip6110_deposits/helpers.py Co-authored-by: Mario Vega <marioevz@gmail.com> * Update tests/prague/eip6110_deposits/test_modified_contract.py Co-authored-by: Mario Vega <marioevz@gmail.com> * Update tests/prague/eip6110_deposits/test_modified_contract.py Co-authored-by: Mario Vega <marioevz@gmail.com> * Update tests/prague/eip6110_deposits/helpers.py Co-authored-by: Mario Vega <marioevz@gmail.com> * Update tests/prague/eip6110_deposits/helpers.py Co-authored-by: Mario Vega <marioevz@gmail.com> * chore(tests): lint * chore(tests): make typecheck say "congratulations" * chore(tests): add pytestmark * chore(tests): remove TODO * Update tests/prague/eip6110_deposits/test_modified_contract.py --------- Co-authored-by: Mario Vega <marioevz@gmail.com>
felix314159
pushed a commit
to felix314159/execution-spec-tests
that referenced
this pull request
May 16, 2025
* new(tests): Add EIP-6110 Sepolia Variant Contract test * fix(tests): Log code * fix(tests): Log code * fix: ABI encoding optional * fix: parametrize for ABI (No-ABI test disabled) * fix(docs): add docs to helper * fix(tests): lint modified_contract (?) * feat(tests): add DEPOSIT_EVENT_SIGNATURE_HASH EIP-6110 * tmp: add sepolia deposit log data * change test and helper methods * convert back to little-endian encoding * feat(helpers): add helper method to construct modified deposit logs * feat(tests): use new helper in modified contract tests * update test modified contract * fix test filler to produce the correct requests hash * feat(tests): add EIP6110 invalid event layout tests * feat(tests): add exception to transaction * cleanup(tests): use DEFAULTs where appropriate * feat(tests): add invalid log length test * chore(tests) lint * Update tests/prague/eip6110_deposits/helpers.py Co-authored-by: Mario Vega <marioevz@gmail.com> * Update tests/prague/eip6110_deposits/helpers.py Co-authored-by: Mario Vega <marioevz@gmail.com> * Update tests/prague/eip6110_deposits/test_modified_contract.py Co-authored-by: Mario Vega <marioevz@gmail.com> * Update tests/prague/eip6110_deposits/test_modified_contract.py Co-authored-by: Mario Vega <marioevz@gmail.com> * Update tests/prague/eip6110_deposits/helpers.py Co-authored-by: Mario Vega <marioevz@gmail.com> * Update tests/prague/eip6110_deposits/helpers.py Co-authored-by: Mario Vega <marioevz@gmail.com> * chore(tests): lint * chore(tests): make typecheck say "congratulations" * chore(tests): add pytestmark * chore(tests): remove TODO * Update tests/prague/eip6110_deposits/test_modified_contract.py --------- Co-authored-by: Mario Vega <marioevz@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
PR built on top of #1280 to add EIP-6110
DepositEventlog layout tests as described in ethereum/EIPs#9460It tests:
Transferevent (Sepolia-like case) (VALID)For each param (
pubkey,withdrawal_credentials,amount,signature,index)🔗 Related Issues
Closes #1360
✅ Checklist
mkdocs servelocally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.