Remove collapse type #88
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylanjw
approved these changes
Jul 30, 2018
carver
reviewed
Jul 30, 2018
docs/releases.rst
Outdated
| @@ -11,6 +11,9 @@ Released July 19, 2018 | |||
| - :meth:`~eth_abi.abi.decode_single` called with ABI type 'string' will now return a python | |||
| :class:`str` instead of :class:`bytes`. | |||
| - Support for the legacy ``real`` and ``ureal`` types has been removed | |||
| - The :meth:`~eth_abi.abi.encode_single` and | |||
| :meth:`~eth_abi.abi.decode_single` functions no longer accept type tuples | |||
| to identify ABI types. Only type strings are accepted. | |||
There was a problem hiding this comment.
Since alpha 1 was already released, this should go into a new version log.
434bc1c to
3c9a285
Compare
Also, modify behavior of `encode_single` and `decode_single` to only accept type strings and not type tuples.
3c9a285 to
ac3bffc
Compare
carver
approved these changes
Aug 29, 2018
|
@carver Yep. There's already a PR for it that I'm going to rebase. |
pacrob
added a commit
to pacrob/eth-abi
that referenced
this pull request
Dec 9, 2023
* remove testall because it doesnt work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
See issue #86 .
How was it fixed?
Removed
collapse_type. Modified behavior ofencode_single,is_encodable, anddecode_single.Cute Animal Picture