Remove process_type utility function #87
Conversation
eth_abi/utils/parsing.py
Outdated
| @@ -1,48 +1,6 @@ | |||
| """ | |||
| This module provided for backwards compatibility. | |||
| """ | |||
| from eth_abi.grammar import ( | |||
| TupleType, | |||
There was a problem hiding this comment.
I must have missed this when it got merged, but worth pointing out now.
The ./project/utils module in our repos has some conventions that help keep those modules well isolated.
- everything in
utilsis private API - anything in
utilsmay not import from outside of utils.
If you have to break the import rule which occasionally happens, the imports should happen inline in the function bodies to prevent circular imports from happening.
There was a problem hiding this comment.
Nice. I'll keep that in mind from here on out.
| ('int[2]', ('int', '256', [[2]])), | ||
| ('function', ('bytes', '24', [])), | ||
| ('fixed', ('fixed', '128x18', [])), | ||
| ('ufixed', ('ufixed', '128x18', [])), |
There was a problem hiding this comment.
Looks like these last three cases aren't tested by the grammar parser https://github.com/ethereum/eth-abi/blob/master/tests/test_grammar.py#L77
Maybe now is a good time to add them.
There was a problem hiding this comment.
Added some tests in the test_grammar module for those cases.
8769858 to
623e907
Compare
What was wrong?
See issue #85 .
How was it fixed?
Removed
process_type.Cute Animal Picture