Return string type as utf-8 decoded string #82
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Im raising a |
a95c9fa to
6172080
Compare
eth_abi/decoding.py
Outdated
| try: | ||
| value = data.decode("utf-8") | ||
| except UnicodeDecodeError as e: | ||
| raise UnicodeDecodeError( |
There was a problem hiding this comment.
This should probably just be the local DecodingError from this library.
There was a problem hiding this comment.
Also, raise ... from e will keep all the original decoding error details in the stack.
8949577 to
c979989
Compare
c979989 to
3af7cd0
Compare
pipermerriam
approved these changes
Jul 19, 2018
|
|
||
| decoder = StringDecoder() | ||
|
|
||
| st.assume(not is_utf8_decodable(_bytes)) |
There was a problem hiding this comment.
Instead of this you can do a .filter() call on the bytes strategy.
from cytoolz import compliment
@given(_bytes=st.binary(...).filter(compliment(is_utf8_decodable)), ...)This should only give you byte strings which are not utf8 decodable.
6a5ff95 to
5ce134b
Compare
pacrob
added a commit
to pacrob/eth-abi
that referenced
this pull request
Dec 9, 2023
* add updates found when merging template with py-ssz and eth-abi * add wheel and wheel-windows to ci and reorg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
string types are return as utf-8 encoded bytes. Makes more sense to return as utf-8 decoded string type.
See #81
How was it fixed?
Added a utf-8 decoding step to the StringDecoder.
Cute Animal Picture