Manually sync eth-abi with ethereum project template #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, correct small error with PyPI license tag.
FWIW the project template was created after eth-abi, so they've never been synced. Props for taking it on! 👀 |
carver
approved these changes
Jun 4, 2018
| @@ -598,6 +594,6 @@ def test_tuple_encoder(): | |||
| UnsignedIntegerEncoder(value_bit_size=256), | |||
| ByteStringEncoder(), | |||
| )) | |||
| expected = decode_hex('0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000004000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000') | |||
| expected = decode_hex('0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000004000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000') # noqa | |||
There was a problem hiding this comment.
The explicit version of the noqa is better here, so we only silence the one line length error.
pacrob
added a commit
to pacrob/eth-abi
that referenced
this pull request
Apr 14, 2023
* new issue and pr templates
pacrob
added a commit
to pacrob/eth-abi
that referenced
this pull request
Dec 9, 2023
* new issue and pr templates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
eth-abihad fallen out of sync with the project template in terms of settings, tools, CI, etc.How was it fixed?
Manually applied differences with project template to
eth-abi. Also correct lint errors and automatically sorted imports.Cute Animal Picture