Update EIP-4527: Move to draft #6013
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A critical exception has occurred: |
|
@axic, @SamWilsn, @Pandapip1 would you please review this change? And I am not sure whether it is ok to move stagnant to review. I checked the EIP-1, from my understanding it is ok to do it. |
Pandapip1
reviewed
Nov 21, 2022
EIPS/eip-4527.md
Outdated
| @@ -4,7 +4,7 @@ title: QR Code data transmission protocol for the offline wallets | |||
| description: QR Code data transmission protocol between wallets and offline signers. | |||
| author: Aaron Chen (@aaronisme), Sora Lee (@soralit), ligi (@ligi), Dan Miller (@danjm), AndreasGassmann (@andreasgassmann), xardass (@xardass), Lixin Liu (@BitcoinLixin) | |||
| discussions-to: https://ethereum-magicians.org/t/add-qr-code-scanning-between-software-wallet-cold-signer-hardware-wallet/6568 | |||
| status: Stagnant | |||
| status: Review | |||
There was a problem hiding this comment.
Must be moved back to draft, since it never made it to review before it was stagnated.
There was a problem hiding this comment.
@Pandapip1 Hi, I have moved it back to draft, please check it out.
Pandapip1
suggested changes
Nov 22, 2022
EIPS/eip-4527.md
Outdated
| @@ -4,17 +4,20 @@ title: QR Code data transmission protocol for the offline wallets | |||
| description: QR Code data transmission protocol between wallets and offline signers. | |||
| author: Aaron Chen (@aaronisme), Sora Lee (@soralit), ligi (@ligi), Dan Miller (@danjm), AndreasGassmann (@andreasgassmann), xardass (@xardass), Lixin Liu (@BitcoinLixin) | |||
| discussions-to: https://ethereum-magicians.org/t/add-qr-code-scanning-between-software-wallet-cold-signer-hardware-wallet/6568 | |||
| status: Stagnant | |||
| status: Draft | |||
There was a problem hiding this comment.
Suggested change
| status: Draft | |
| status: Draft |
This is a small typo, but it blocks this PR.
There was a problem hiding this comment.
Hi @Pandapip1 I have updated the file, would you please check it again?
Pandapip1
suggested changes
Nov 24, 2022
EIPS/eip-4527.md
Outdated
Comment on lines
231
to
237
| This reference implementation is in Javascript and available at: https://github.com/KeystoneHQ/keystone-airgaped-base/tree/master/packages/ur-registry-eth | ||
|
|
||
| Metamask has adopted it for its integration with QR-based Signers. https://github.com/MetaMask/metamask-extension/pull/12065 | ||
|
|
||
| BlockchainCommons Uniform Resources: https://github.com/BlockchainCommons/Research/blob/master/papers/bcr-2020-005-ur.md | ||
|
|
||
| BlockchainCommons UR Types: https://github.com/BlockchainCommons/Research/blob/master/papers/bcr-2020-006-urtypes.md |
EIPS/eip-4527.md
Outdated
| BlockchainCommons Uniform Resources: https://github.com/BlockchainCommons/Research/blob/master/papers/bcr-2020-005-ur.md | ||
|
|
||
| BlockchainCommons UR Types: https://github.com/BlockchainCommons/Research/blob/master/papers/bcr-2020-006-urtypes.md | ||
|
|
||
| Here is a video that shows how it works: https://www.youtube.com/watch?v=1eM53TYG1YA |
EIPS/eip-4527.md
Outdated
| Currently, there is no existing protocol to define data transmissions via QR Codes so there are no backward compatibility issues that needs to be addressed now. | ||
|
|
||
| ## Test Cases | ||
| The reference implementation contains the [test cases](https://github.com/KeystoneHQ/keystone-airgaped-base/tree/master/packages/ur-registry-eth/__tests__). | ||
|
|
||
| The reference implementation contains the `test cases`: https://github.com/KeystoneHQ/keystone-airgaped-base/tree/master/packages/ur-registry-eth/__tests__ |
|
@Pandapip1 I have fixed the comments as requested, Please check thanks |
Pandapip1
reviewed
Nov 25, 2022
EIPS/eip-4527.md
Outdated
Comment on lines
233
to
235
| Metamask has adopted it for its integration with QR-based Signers. https://github.com/MetaMask/metamask-extension/pull/12065 | ||
|
|
||
| Here is a video that shows how it works: https://www.youtube.com/watch?v=1eM53TYG1YA |
There was a problem hiding this comment.
Suggested change
| Metamask has adopted it for its integration with QR-based Signers. https://github.com/MetaMask/metamask-extension/pull/12065 | |
| Here is a video that shows how it works: https://www.youtube.com/watch?v=1eM53TYG1YA |
|
@Pandapip1 I have updated the file as requested |
Pandapip1
approved these changes
Nov 27, 2022
eth-bot
approved these changes
Nov 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update some mirror change to the EIP and move it into review