Skip to content

Conversation

TimDaub
Copy link
Contributor

@TimDaub TimDaub commented Sep 15, 2022

Heavily inspired by EIP-3722 of @auryn-macmillan

@TimDaub TimDaub requested a review from eth-bot as a code owner September 15, 2022 15:22
@github-actions github-actions bot added c-new Creates a brand new proposal e-number Waiting on EIP Number assignment s-draft This EIP is a Draft t-erc labels Sep 15, 2022
@eth-bot
Copy link
Collaborator

eth-bot commented Sep 15, 2022

Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):


(fail) eip-5659.md

classification
newEIPFile

Co-authored-by: xinbenlv <zzn@zzn.im>
@github-actions github-actions bot removed the e-number Waiting on EIP Number assignment label Sep 17, 2022
@Pandapip1 Pandapip1 changed the title Add: Social Media URI Propagation Event Add EIP-5659: Social Media URI Propagation Event Sep 18, 2022

## Motivation

The modern social network's base layer is distributing content behind Universal Resource Identifiers as defined by RFC 3986. Any web resource can be identified by an URI or a URL and so upgrading Ethereum with a standard way of distributing content is useful.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You haven't convinced me that this EIP needs to exist. I think I'd like to see some potential use cases, both for publishers and for event consumers.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, how would you frame this in the context of an EIP though? E.g. I feel like pointing out the countless problems of web2 content distribution could read too political

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you need to bash web2 to make a case for this EIP. What URIs do you expect to publish? Who do you expect to consume them? What applications are difficult to implement without this standard? These questions, answered in your Motivation section, would make for a more compelling proposal.


## Abstract

We introduce a minimal on-chain primitive to emit URIs using Ethereum's event log infrastructure.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We like terse abstracts, but this is perhaps a touch too short. Perhaps include a brief summary of what kinds of URIs you expect people to publish?

Comment on lines +26 to +28
function submit(string calldata uri) external {
emit NewPost(msg.sender, uri);
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this implementation the only valid implementation? If not, you should probably switch this to an interface and let implementers decide how to implement it.

@github-actions
Copy link

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

@github-actions github-actions bot added w-stale Waiting on activity and removed w-stale Waiting on activity labels Nov 25, 2022
@github-actions
Copy link

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

@github-actions github-actions bot added the w-stale Waiting on activity label Dec 24, 2022
@github-actions
Copy link

github-actions bot commented Feb 4, 2023

This pull request was closed due to inactivity. If you are still pursuing it, feel free to reopen it and respond to any feedback or request a review in a comment.

@github-actions github-actions bot closed this Feb 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-new Creates a brand new proposal s-draft This EIP is a Draft t-erc w-stale Waiting on activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants