-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Add EIP-5659: Social Media URI Propagation Event #5659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s): (fail) eip-5659.md
|
Co-authored-by: xinbenlv <zzn@zzn.im>
|
||
## Motivation | ||
|
||
The modern social network's base layer is distributing content behind Universal Resource Identifiers as defined by RFC 3986. Any web resource can be identified by an URI or a URL and so upgrading Ethereum with a standard way of distributing content is useful. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You haven't convinced me that this EIP needs to exist. I think I'd like to see some potential use cases, both for publishers and for event consumers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, how would you frame this in the context of an EIP though? E.g. I feel like pointing out the countless problems of web2 content distribution could read too political
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think you need to bash web2 to make a case for this EIP. What URIs do you expect to publish? Who do you expect to consume them? What applications are difficult to implement without this standard? These questions, answered in your Motivation section, would make for a more compelling proposal.
|
||
## Abstract | ||
|
||
We introduce a minimal on-chain primitive to emit URIs using Ethereum's event log infrastructure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We like terse abstracts, but this is perhaps a touch too short. Perhaps include a brief summary of what kinds of URIs you expect people to publish?
function submit(string calldata uri) external { | ||
emit NewPost(msg.sender, uri); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this implementation the only valid implementation? If not, you should probably switch this to an interface and let implementers decide how to implement it.
There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review. |
There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review. |
This pull request was closed due to inactivity. If you are still pursuing it, feel free to reopen it and respond to any feedback or request a review in a comment. |
Heavily inspired by EIP-3722 of @auryn-macmillan