fix check parts for tests #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix when resolved glauth#246
Thank you for making a pull request!
A few things to be aware of as you're working on your PR:
WIP Tag
Incomplete PRs are more than welcome - it can be useful to collaborate before
implementation of an idea is complete. However, if your PR is not ready
for merge, please add [WIP] to the end of the title (work-in-progress).
Tests
Before committing, you are encouraged to run the small but growing test
suite. This is accomplished by
make test. Additionally, if you are addingnew functionality, consider adding tests covering your feature.
CI
Each push to a branch connected to a PR will be run through GLAuth's CI system. Please use these to your advantage. In
particular, the Github Actions integration tests rely on the LDAP queries returning with a set result, so if your
changes will change the output, CI will likely fail.
To update, run
make fast && make updatetest && make test. This will delete the output snapshots provided and make newones. You can then inspect the changes and commit them.
Similarly, check codeclimate and try to fix what you find there if it fails.