Skip to content

vendor: update x/sys and x/net modules to support Risc-V #10834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 29, 2019
Merged

vendor: update x/sys and x/net modules to support Risc-V #10834

merged 1 commit into from
Aug 29, 2019

Conversation

carlosedp
Copy link
Contributor

Updating projects using libraries that were recently updated to support Risc-V architecture.

Go upstream work is tracked on: golang/go#27532

Risc-V software support tracker on https://github.com/carlosedp/riscv-bringup

Signed-off-by: CarlosEDP me@carlosedp.com

@codecov-io
Copy link

codecov-io commented Jun 18, 2019 •
edited by codecov bot
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.47%. Comparing base (02ed271) to head (434c973).

⚠️ Current head 434c973 differs from pull request most recent head 7c6ef60

Please upload reports for the commit 7c6ef60 to get more accurate results.

Additional details and impacted files

see 27 files with indirect coverage changes

@@            Coverage Diff             @@
##           master   #10834      +/-   ##
==========================================
+ Coverage   63.65%   64.47%   +0.82%     
==========================================
  Files         402      402              
  Lines       37719    37712       -7     
==========================================
+ Hits        24010    24315     +305     
+ Misses      12081    11773     -308     
+ Partials     1628     1624       -4

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d21017...7c6ef60. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@carlosedp carlosedp changed the title Update x/sys and x/net modules to support Risc-V all: update x/sys and x/net modules to support Risc-V Aug 12, 2019
@carlosedp
Copy link
Contributor Author

Due to the Go module timestamp check, grpc 1.22.1 was failing with error:

go: google.golang.org/grpc@v1.22.1-0.20190805101010-a2bdfb40ff25: invalid pseudo-version: does not match version-control timestamp (2019-08-06T16:34:46Z)

Updating to named 1.22.1 version fixes this.

@carlosedp
Copy link
Contributor Author

Rebased and updated x/net due to a new validation by Go 1.13:

GO_BUILD_FLAGS="-v" ./build
get "golang.org/x/net": found meta tag get.metaImport{Prefix:"golang.org/x/net", VCS:"git", RepoRoot:"https://go.googlesource.com/net"} at //golang.org/x/net?go-get=1
go: golang.org/x/net@v0.0.0-20190813000000-74dc4d7220e7: invalid pseudo-version: does not match version-control timestamp (2019-08-13T14:13:03Z)
make: *** [Makefile:15: build] Error 1

@gyuho
Copy link
Contributor

gyuho commented Aug 29, 2019

@carlosedp Can you change git commit title to vendor: ...?

@carlosedp
vendor: x/sys and x/net to support building on Risc-V
7c6ef60 
Signed-off-by: Carlos de Paula <me@carlosedp.com>
@carlosedp carlosedp changed the title all: update x/sys and x/net modules to support Risc-V vendor: update x/sys and x/net modules to support Risc-V Aug 29, 2019
@carlosedp
Copy link
Contributor Author

@gyuho Done! Changed the PR title too.

@carlosedp
Copy link
Contributor Author

Passed all! 💯

@gyuho gyuho merged commit 876df8d into etcd-io:master Aug 29, 2019
@wenjiaswe wenjiaswe mentioned this pull request Oct 24, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@gyuho gyuho gyuho approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carlosedp @codecov-io @gyuho