Upgrade grpc-gateway from v1 to v2 #16595
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @johanbrandhorst as well. Please kindly let's know if you have any concern. |
johanbrandhorst
approved these changes
Sep 13, 2023
|
|
||
| trap cleanup_googleapi EXIT | ||
|
|
||
| # TODO(ahrtr): use buf (https://github.com/bufbuild/buf) to manage the protobuf dependencies? |
fuweid
reviewed
Sep 14, 2023
f4ebc61 to
dc1172a
Compare
|
This PR is trying to resolve an important task tracked in 3.6 roadmap. Ping all etcd maintainers to take a look, thx. |
serathius
reviewed
Sep 18, 2023
serathius
reviewed
Sep 18, 2023
serathius
reviewed
Sep 18, 2023
|
@tao12345666333 @CyberDem0n & anyone else, Could you please also verify this PR on your project, so as to make sure it doesn't break anything? Thanks. |
Signed-off-by: Wei Fu <fuweid89@gmail.com> Signed-off-by: Benjamin Wang <wachao@vmware.com>
Run ./scripts/genproto.sh Signed-off-by: Benjamin Wang <wachao@vmware.com> Signed-off-by: Wei Fu <fuweid89@gmail.com>
…s to v2 messages Signed-off-by: Benjamin Wang <wachao@vmware.com> Signed-off-by: Wei Fu <fuweid89@gmail.com>
…2.17.1 for all modules Signed-off-by: Benjamin Wang <wachao@vmware.com>
1. Manually updated go source file to remove the usage of v1 grpc-gateway; 2. Execute ./scripts/fix.sh Signed-off-by: Benjamin Wang <wachao@vmware.com> Signed-off-by: Wei Fu <fuweid89@gmail.com>
Signed-off-by: Benjamin Wang <wachao@vmware.com>
…script or code Signed-off-by: Benjamin Wang <wachao@vmware.com>
serathius
approved these changes
Sep 18, 2023
tao12345666333
approved these changes
Sep 19, 2023
|
thx all. @fuweid @johanbrandhorst @serathius @tao12345666333 Especially a big THANK YOU to @fuweid, who demonstrated deep understanding on both etcd and grpc-gateway/protobuf. |
This was referenced Sep 19, 2023
9 tasks
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gogo/protobuf. We only bump grpc-gateway from v1 to v2 in this PR, so as to avoid any potential compatibility issues betweengogo/protobufandprotobuf-go v2cc @fuweid @jmhbnz @mitake @ptabor @serathius @spzala @wenjiaswe @dims @liggitt
To clarify, although this PR looks huge, but actually majority source code are generated by protoc plugins.