Skip to content

etcd depends on two different versions of the same package - grpc-gateway #14499

@dims

Description

@dims

If you see the bill-of-materials.json, you will see both "github.com/grpc-ecosystem/grpc-gateway/v2" and "github.com/grpc-ecosystem/grpc-gateway"
https://github.com/etcd-io/etcd/blob/main/bill-of-materials.json#L264-L280

Can we please switch to /v2 version as this is needed by the new otel libraries?

[dims@dims-m1-7728 22:12] ~/go/src/github.com/etcd-io/etcd ⟩ go mod graph | grep github.com/grpc-ecosystem/grpc-gateway/v2
go.etcd.io/etcd/v3 github.com/grpc-ecosystem/grpc-gateway/v2@v2.7.0
github.com/grpc-ecosystem/grpc-gateway/v2@v2.7.0 github.com/antihax/optional@v1.0.0
github.com/grpc-ecosystem/grpc-gateway/v2@v2.7.0 github.com/ghodss/yaml@v1.0.0
github.com/grpc-ecosystem/grpc-gateway/v2@v2.7.0 github.com/golang/glog@v1.0.0
github.com/grpc-ecosystem/grpc-gateway/v2@v2.7.0 github.com/golang/protobuf@v1.5.2
github.com/grpc-ecosystem/grpc-gateway/v2@v2.7.0 github.com/google/go-cmp@v0.5.6
github.com/grpc-ecosystem/grpc-gateway/v2@v2.7.0 github.com/rogpeppe/fastuuid@v1.2.0
github.com/grpc-ecosystem/grpc-gateway/v2@v2.7.0 golang.org/x/oauth2@v0.0.0-20211104180415-d3ed0bb246c8
github.com/grpc-ecosystem/grpc-gateway/v2@v2.7.0 google.golang.org/genproto@v0.0.0-20211118181313-81c1377c94b1
github.com/grpc-ecosystem/grpc-gateway/v2@v2.7.0 google.golang.org/grpc@v1.42.0
github.com/grpc-ecosystem/grpc-gateway/v2@v2.7.0 google.golang.org/protobuf@v1.27.1
go.etcd.io/etcd/server/v3@v3.6.0-alpha.0 github.com/grpc-ecosystem/grpc-gateway/v2@v2.7.0
go.etcd.io/etcd/tests/v3@v3.6.0-alpha.0 github.com/grpc-ecosystem/grpc-gateway/v2@v2.7.0
go.opentelemetry.io/proto/otlp@v0.16.0 github.com/grpc-ecosystem/grpc-gateway/v2@v2.7.0

The older one is references here:

[dims@dims-m1-7728 22:12] ~/go/src/github.com/etcd-io/etcd ⟩ go mod graph | grep github.com/grpc-ecosystem/grpc-gateway | grep -v v2
go.etcd.io/etcd/v3 github.com/grpc-ecosystem/grpc-gateway@v1.16.0
github.com/grpc-ecosystem/grpc-gateway@v1.16.0 github.com/antihax/optional@v1.0.0
github.com/grpc-ecosystem/grpc-gateway@v1.16.0 github.com/ghodss/yaml@v1.0.0
github.com/grpc-ecosystem/grpc-gateway@v1.16.0 github.com/golang/glog@v0.0.0-20160126235308-23def4e6c14b
github.com/grpc-ecosystem/grpc-gateway@v1.16.0 github.com/golang/protobuf@v1.3.3
github.com/grpc-ecosystem/grpc-gateway@v1.16.0 github.com/rogpeppe/fastuuid@v1.2.0
github.com/grpc-ecosystem/grpc-gateway@v1.16.0 golang.org/x/net@v0.0.0-20200822124328-c89045814202
github.com/grpc-ecosystem/grpc-gateway@v1.16.0 golang.org/x/oauth2@v0.0.0-20200107190931-bf48bf16ab8d
github.com/grpc-ecosystem/grpc-gateway@v1.16.0 golang.org/x/xerrors@v0.0.0-20200804184101-5ec99f83aff1
github.com/grpc-ecosystem/grpc-gateway@v1.16.0 google.golang.org/genproto@v0.0.0-20200513103714-09dca8ec2884
github.com/grpc-ecosystem/grpc-gateway@v1.16.0 google.golang.org/grpc@v1.33.1
go.etcd.io/etcd/api/v3@v3.6.0-alpha.0 github.com/grpc-ecosystem/grpc-gateway@v1.16.0
go.etcd.io/etcd/server/v3@v3.6.0-alpha.0 github.com/grpc-ecosystem/grpc-gateway@v1.16.0
go.etcd.io/etcd/tests/v3@v3.6.0-alpha.0 github.com/grpc-ecosystem/grpc-gateway@v1.16.0
go.opentelemetry.io/proto/otlp@v0.7.0 github.com/grpc-ecosystem/grpc-gateway@v1.16.0

Would kindly request this to be cherry-picked on 3.5.x branch as well! (so we can then pick it up for kubernetes/kubernetes).

thanks!

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions