Skip to content

Conversation

HoxhaEndri
Copy link
Member

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    It checks for the versions of emba, git and docker. It uses a new script to update the VERSION.txt file.

  • What is the current behavior? (You can also link to an open issue here)

  • What is the new behavior (if this is a feature change)? If possible add a screenshot.

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

  • Other information:

@HoxhaEndri HoxhaEndri requested a review from m-1-k-3 November 29, 2023 10:33
Copy link
Member

@m-1-k-3 m-1-k-3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool PR with valuable details regarding updates. Could you please check my comments?

@m-1-k-3 m-1-k-3 added enhancement New feature or request EMBA labels Nov 29, 2023
@HoxhaEndri HoxhaEndri requested a review from m-1-k-3 November 29, 2023 14:22
Copy link
Member

@m-1-k-3 m-1-k-3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please merge the current master of EMBA to ensure everything will run smooth

@m-1-k-3
Copy link
Member

m-1-k-3 commented Nov 30, 2023

This looks really useful

image

@HoxhaEndri HoxhaEndri requested a review from m-1-k-3 November 30, 2023 10:51
@m-1-k-3 m-1-k-3 merged commit 1a06924 into e-m-b-a:master Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EMBA enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants