Skip to content

Conversation

m-1-k-3
Copy link
Member

@m-1-k-3 m-1-k-3 commented Apr 16, 2024

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Bug fix

  • What is the current behavior? (You can also link to an open issue here)

helpers local/export vars
status bar issues

  • What is the new behavior (if this is a feature change)? If possible add a screenshot.

fixed vars
status bar should work better - closes #461
closes #1070

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

  • Other information:

@m-1-k-3 m-1-k-3 added bug Something isn't working EMBA labels Apr 16, 2024
@m-1-k-3
Copy link
Member Author

m-1-k-3 commented Apr 16, 2024

ping @torabi12

@torabi12
Copy link

I changed the terminal size many times during the scan, it was working fine in small:

kép

in big:
kép

Rarely the refresh was not perfect:
kép

But after resizing again it was ok.
At the end was like this:

kép

In summary the behaviour is much better than before with status bar. Thank you!

@m-1-k-3 m-1-k-3 marked this pull request as ready for review April 16, 2024 16:13
@m-1-k-3
Copy link
Member Author

m-1-k-3 commented Apr 16, 2024

@torabi12 should also address #1070

@torabi12
Copy link

@torabi12 should also address #1070

I can check the #1070 tomorrow I hope.
May I try again the status bar test today?

@m-1-k-3
Copy link
Member Author

m-1-k-3 commented Apr 16, 2024

status bar looks good to me. The artefacts are looking quite small. If they do not destroy the rest of the behavior it is fine for me

@torabi12
Copy link

status bar looks good to me. The artefacts are looking quite small. If they do not destroy the rest of the behavior it is fine for me

Yes, it was appropriate. Thanks again!

@HoxhaEndri HoxhaEndri merged commit b4d6e11 into e-m-b-a:master Apr 17, 2024
@m-1-k-3 m-1-k-3 deleted the vars_check branch February 13, 2025 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working EMBA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

p55_unblob_extractor error messages Status bar rendering stability
3 participants