Skip to content

Conversation

m-1-k-3
Copy link
Member

@m-1-k-3 m-1-k-3 commented Feb 28, 2025

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Feature

  • What is the current behavior? (You can also link to an open issue here)

no cve-db import

  • What is the new behavior (if this is a feature change)? If possible add a screenshot.

prepare everything to allow db imports

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

With this PR we have the possibility to import the sqlite database for the CVE detection via cve-bin-tool. We will have a database in the docker container. Nevertheless, if someone wants to update the local database a cve-bin-tool installation is needed for updating it:

cve-bin-tool --update
cve-bin-tool --export EMBA_INSTALL_DIR/config/cve-bin-tool.db

As we relay on the free github environment we will not provide these updates!

See also the EMBA update section: https://github.com/e-m-b-a/emba/wiki/EMBA-update

  • Other information:

@m-1-k-3 m-1-k-3 added enhancement New feature or request cve-search Some cve-search question/issue EMBA labels Feb 28, 2025
@m-1-k-3 m-1-k-3 marked this pull request as ready for review March 1, 2025 13:08
@m-1-k-3 m-1-k-3 requested a review from BenediktMKuehne March 1, 2025 13:08
@@ -85,8 +85,7 @@ IL15_emulated_checks_init() {
# EMBAbite fuzzer used this:
# pip_install "upnpclient"
pip_install "lxml==5.3.1"
pip_install "upnpclient" "--no-dependencies lxml"

pip3 install "upnpclient" --no-dependencies lxml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why pip directly
Would add comment

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point. Our current pip_install helper function does not support further parameters.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@m-1-k-3 m-1-k-3 merged commit 3e54a50 into e-m-b-a:master Mar 1, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cve-search Some cve-search question/issue EMBA enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants